From 7a94f78d784afb1d91848aee48e7ad97833b04f0 Mon Sep 17 00:00:00 2001 From: advplyr Date: Mon, 13 Jan 2025 17:08:22 -0600 Subject: [PATCH] Update bookmark timestamps to be relative to playback speed #1148 --- components/app/AudioPlayerContainer.vue | 2 +- components/modals/BookmarksModal.vue | 18 +++++++++++++----- components/modals/bookmarks/BookmarkItem.vue | 8 ++++---- 3 files changed, 18 insertions(+), 10 deletions(-) diff --git a/components/app/AudioPlayerContainer.vue b/components/app/AudioPlayerContainer.vue index f9178f09..fe3f569d 100644 --- a/components/app/AudioPlayerContainer.vue +++ b/components/app/AudioPlayerContainer.vue @@ -4,7 +4,7 @@ - + diff --git a/components/modals/BookmarksModal.vue b/components/modals/BookmarksModal.vue index 8b8284d9..7b768de8 100644 --- a/components/modals/BookmarksModal.vue +++ b/components/modals/BookmarksModal.vue @@ -7,14 +7,14 @@
-
+
arrow_back

{{ selectedBookmark ? 'Edit Bookmark' : 'New Bookmark' }}

-

{{ this.$secondsToTimestamp(currentTime) }}

+

{{ this.$secondsToTimestamp(currentTime / _playbackRate) }}

@@ -22,9 +22,9 @@ {{ selectedBookmark ? 'Update' : 'Create' }}
-
+

{{ $strings.MessageNoBookmarks }}

@@ -32,7 +32,7 @@
add

{{ $strings.ButtonCreateBookmark }}

-

{{ this.$secondsToTimestamp(currentTime) }}

+

{{ this.$secondsToTimestamp(currentTime / _playbackRate) }}

@@ -54,6 +54,10 @@ export default { type: Number, default: 0 }, + playbackRate: { + type: Number, + default: 1 + }, libraryItemId: String }, data() { @@ -82,6 +86,10 @@ export default { }, canCreateBookmark() { return !this.bookmarks.find((bm) => bm.time === this.currentTime) + }, + _playbackRate() { + if (!this.playbackRate || isNaN(this.playbackRate)) return 1 + return this.playbackRate } }, methods: { diff --git a/components/modals/bookmarks/BookmarkItem.vue b/components/modals/bookmarks/BookmarkItem.vue index bdfbd7f2..b6c2e54b 100644 --- a/components/modals/bookmarks/BookmarkItem.vue +++ b/components/modals/bookmarks/BookmarkItem.vue @@ -7,7 +7,7 @@ {{ bookmark.title }}

-

schedule{{ $secondsToTimestamp(bookmark.time) }}

+

schedule{{ $secondsToTimestamp(bookmark.time / playbackRate) }}

edit @@ -23,7 +23,8 @@ export default { type: Object, default: () => {} }, - highlight: Boolean + highlight: Boolean, + playbackRate: Number }, data() { return {} @@ -39,7 +40,6 @@ export default { editClick() { this.$emit('edit', this.bookmark) } - }, - mounted() {} + } } \ No newline at end of file