From 8340cdbab2f2d60c1a41d7c077b9905c3c94a7f1 Mon Sep 17 00:00:00 2001 From: Franck Nijhof Date: Thu, 5 Mar 2020 22:20:51 +0100 Subject: [PATCH] Remove sRGB requirement for now, until we have better checks --- .github/PULL_REQUEST_TEMPLATE.md | 1 - .github/workflows/validate/validate.sh | 7 +------ README.md | 1 - 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 621b32b5..0ab88044 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -42,7 +42,6 @@ --> - [ ] The added/replaced image(s) are **PNG** -- [ ] The added/replaced image(s) are in the **rRGB** color space - [ ] Icon image size is 256x256px (`icon.png`) - [ ] hDPI icon image size is 512x512px for (`icon@2x.png`) - [ ] Logo image size has min 128px, but max 256px, on the shortest side (`logo.png`) diff --git a/.github/workflows/validate/validate.sh b/.github/workflows/validate/validate.sh index af4a6080..b918a29e 100755 --- a/.github/workflows/validate/validate.sh +++ b/.github/workflows/validate/validate.sh @@ -20,7 +20,7 @@ function error() { # Find all files in the src folder (should contain only images) while read image; do # Read properties from image - properties=($(identify -format "%w %h %m %[colorspace]" "${image}")) + properties=($(identify -format "%w %h %m" "${image}")) if [[ "$?" -ne 0 ]]; then error "${image}" "Could not read image file" continue @@ -31,16 +31,11 @@ while read image; do width="${properties[0]}" height="${properties[1]}" type="${properties[2]}" - colorspace="${properties[3]}" # Ensure file is actually a PNG file [[ "${type}" != "PNG" ]] \ && error "${image}" "Invalid file type '${type}' for file" - # Ensure color space is sRGB - [[ "${colorspace}" != "sRGB" ]] \ - && error "${image}" "Invalid color space '${colorspace}' for file" - # Validate image dimensions if [[ "${filename}" == "icon.png" ]]; then # icon dimension diff --git a/README.md b/README.md index 98c26729..93b1f33f 100644 --- a/README.md +++ b/README.md @@ -49,7 +49,6 @@ our cache. All images must have the following requirements: - The filetype of all images must be PNG. -- The color space of all images must be rRGB. - They should be properly compressed and optimized (lossless is preferred) for use on the web. - Interlaced is preferred (also known as progressive). - Images with transparency is preferred.