From a2ea443fd103df92a344a15f50eaf82b8e34e323 Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Sat, 2 Nov 2019 19:21:11 +0000 Subject: [PATCH 1/5] Add descriptions of non-free network services used by AnkiDroid Attempt to add more transparency to the description by describing exactly what network services might receive data from the app, their default off / opt-in nature, and what we do with the data. --- metadata/com.ichi2.anki.yml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/metadata/com.ichi2.anki.yml b/metadata/com.ichi2.anki.yml index a8b5fa4c7c..40df8d75c9 100644 --- a/metadata/com.ichi2.anki.yml +++ b/metadata/com.ichi2.anki.yml @@ -15,11 +15,19 @@ Description: |- efficient than traditional study methods, you can either greatly decrease your time spent studying, or greatly increase the amount you learn. AnkiDroid is the Android port of Anki, and is compatible with Anki data. - - Synchronization uses the non-free AnkiWeb service by default, but this can be + + Opt-in synchronization uses the non-free AnkiWeb service by default, but this can be changed in the settings to use, for example, an instance of the unofficial [https://github.com/ankicommunity/anki-sync-server Anki Sync Server]). + Opt-in / off-by-default crash reporting will send data to a private / AnkiDroid + open source team controlled crash reporting server if enabled. This data is only + used to help fix crash bugs. + + Opt-in / off-by-default analytics will send data to Google Analytics via an + an open-source implementation of the analytics API if enabled. This data is only + used to focus developer efforts on popular features. + RepoType: git Repo: https://github.com/ankidroid/Anki-Android.git From b72afac94431563de25491a9e70b5aa0be5ca650 Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Sat, 2 Nov 2019 21:58:57 +0000 Subject: [PATCH 2/5] Add AntiFeature NonFreeNet to metadata This matches the descriptions below it --- metadata/com.ichi2.anki.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/metadata/com.ichi2.anki.yml b/metadata/com.ichi2.anki.yml index 40df8d75c9..dcba875f7a 100644 --- a/metadata/com.ichi2.anki.yml +++ b/metadata/com.ichi2.anki.yml @@ -8,6 +8,8 @@ SourceCode: https://github.com/ankidroid/Anki-Android IssueTracker: https://github.com/ankidroid/Anki-Android/issues Translation: http://crowdin.net/project/ankidroid Changelog: https://ankidroid.org/docs/changelog.html +AntiFeatures: + - NonFreeNet AutoName: AnkiDroid Description: |- From d681ef038f1ede1680cc684a23f10b6467b5c9ce Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Sat, 2 Nov 2019 22:10:03 +0000 Subject: [PATCH 3/5] Fix formatting errors per rewritemeta output --- metadata/com.ichi2.anki.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/metadata/com.ichi2.anki.yml b/metadata/com.ichi2.anki.yml index dcba875f7a..56320b91d2 100644 --- a/metadata/com.ichi2.anki.yml +++ b/metadata/com.ichi2.anki.yml @@ -1,3 +1,5 @@ +AntiFeatures: + - NonFreeNet Categories: - Science & Education License: GPL-3.0-only @@ -8,8 +10,6 @@ SourceCode: https://github.com/ankidroid/Anki-Android IssueTracker: https://github.com/ankidroid/Anki-Android/issues Translation: http://crowdin.net/project/ankidroid Changelog: https://ankidroid.org/docs/changelog.html -AntiFeatures: - - NonFreeNet AutoName: AnkiDroid Description: |- @@ -17,7 +17,7 @@ Description: |- efficient than traditional study methods, you can either greatly decrease your time spent studying, or greatly increase the amount you learn. AnkiDroid is the Android port of Anki, and is compatible with Anki data. - + Opt-in synchronization uses the non-free AnkiWeb service by default, but this can be changed in the settings to use, for example, an instance of the unofficial [https://github.com/ankicommunity/anki-sync-server Anki Sync Server]). @@ -25,7 +25,7 @@ Description: |- Opt-in / off-by-default crash reporting will send data to a private / AnkiDroid open source team controlled crash reporting server if enabled. This data is only used to help fix crash bugs. - + Opt-in / off-by-default analytics will send data to Google Analytics via an an open-source implementation of the analytics API if enabled. This data is only used to focus developer efforts on popular features. From 471a2b0a53900336563172e5ce7a8c64d0365447 Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Sat, 2 Nov 2019 22:17:45 +0000 Subject: [PATCH 4/5] Remove trailing whitespace reported by lint --- metadata/com.ichi2.anki.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metadata/com.ichi2.anki.yml b/metadata/com.ichi2.anki.yml index 56320b91d2..c4f2d37a0f 100644 --- a/metadata/com.ichi2.anki.yml +++ b/metadata/com.ichi2.anki.yml @@ -22,7 +22,7 @@ Description: |- changed in the settings to use, for example, an instance of the unofficial [https://github.com/ankicommunity/anki-sync-server Anki Sync Server]). - Opt-in / off-by-default crash reporting will send data to a private / AnkiDroid + Opt-in / off-by-default crash reporting will send data to a private / AnkiDroid open source team controlled crash reporting server if enabled. This data is only used to help fix crash bugs. From 880a3051974bca89bada744f2474c8d66eafc37f Mon Sep 17 00:00:00 2001 From: Mike Hardy Date: Sat, 2 Nov 2019 22:24:48 +0000 Subject: [PATCH 5/5] Re-enable 2.9.1 --- metadata/com.ichi2.anki.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/metadata/com.ichi2.anki.yml b/metadata/com.ichi2.anki.yml index c4f2d37a0f..5d1da5e227 100644 --- a/metadata/com.ichi2.anki.yml +++ b/metadata/com.ichi2.anki.yml @@ -398,7 +398,6 @@ Builds: - versionName: 2.9.1 versionCode: 20901300 - disable: Analytics lib regex see admin/issues/144 commit: v2.9.1 subdir: AnkiDroid gradle: