From e75b97ec2add1c49eefc8135be7adf3aead1802c Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Wed, 21 Jun 2023 09:55:41 +0200 Subject: [PATCH] enable CODEOWNERS file to enforce reviews on key files * The plan is to migrate as much config as possible to a config.yml file that is committed to fdroiddata. That means it must not be accessible for a single contributor to change. The risks of breakage or abuse are too high. * The GitLab CI setup is essential, complex, and interwoven into many other pieces. Any changes should be reviewed, not just pushed. * Some changes need to be checked by CI, so they should go through merge requests. --- .gitlab/CODEOWNERS | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .gitlab/CODEOWNERS diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS new file mode 100644 index 0000000000..8eb09fca16 --- /dev/null +++ b/.gitlab/CODEOWNERS @@ -0,0 +1,21 @@ + +# These rarely need to be changed, and changes can have big impacts. +[Three Approvers][3] @fdroid +config.yml +config/channels.yml +config/config.yml +config/*.png +config/*/config.yml +config/*/*.png + + +[Review Required][2] @fdroid +.gitlab-ci.yml +.gitlab/ + + +[Merge Request Required] @fdroid +config/antiFeatures.yml +config/categories.yml +config/*/antiFeatures.yml +config/*/categories.yml