sudoxreboot/habitica-android
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica-android.git synced 2026-05-22 21:57:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Skip redundant markdown parses to reduce flash

Browse source 
Track last-parsed Spanned in existingMarkdownText/Notes and bail out if identical, so we don’t reset the view’s content (markdown in title/notes) every bind.

View height still recalculates on refresh (minor layout flash), but the markdown text no longer "flickers".
This commit is contained in:
Hafiz 2025-06-10 13:18:17 -05:00 committed by Phillip Thelen
parent c8d42dfbf0
commit 1bfb5b3ff3
1 changed files with 29 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
Habitica/src/main/java/com/habitrpg/android/habitica/ui/viewHolders/tasks/BaseTaskViewHolder.kt
View file

@ -1,6 +1,7 @@
package com.habitrpg.android.habitica.ui.viewHolders.tasks
import android.content.Context
import android.text.Spanned
import android.text.method.LinkMovementMethod
import android.view.MotionEvent
import android.view.View
@ -37,6 +38,8 @@ abstract class BaseTaskViewHolder(
private val scope = MainScope()
var task: Task? = null
var existingMarkdownText: Spanned? = null
var existingMarkdownNotes: Spanned? = null
var movingFromPosition: Int? = null
var errorButtonClicked: (() -> Unit)? = null
var userID: String? = null
@ -169,24 +172,41 @@ abstract class BaseTaskViewHolder(
notesTextView?.visibility = View.GONE
}
titleTextView.text = data.text
scope.launch(Dispatchers.IO) {
if (data.text.isNotEmpty() && MarkdownParser.containsMarkdown(data.text)) {
val parsedText = MarkdownParser.parseMarkdown(data.text)
withContext(Dispatchers.Main) {
data.parsedText = parsedText
titleTextView.setParsedMarkdown(parsedText)
val text = data.text ?: ""
if (!MarkdownParser.containsMarkdown(text)) {
titleTextView.text = text
existingMarkdownText = null
} else {
scope.launch(Dispatchers.IO) {
if (text.isNotEmpty() && MarkdownParser.containsMarkdown(text)) {
val parsedText = MarkdownParser.parseMarkdown(text)
if (existingMarkdownText != null && existingMarkdownText == parsedText) {
return@launch
}
existingMarkdownText = parsedText
withContext(Dispatchers.Main) {
data.parsedText = parsedText
titleTextView.setParsedMarkdown(parsedText)
}
}
}
}
if (displayMode != "minimal") {
notesTextView?.text = data.notes
data.notes?.let { notes ->
val notes = data.notes ?: ""
if (!MarkdownParser.containsMarkdown(notes)) {
notesTextView?.text = data.notes
existingMarkdownNotes = null
} else {
scope.launch(Dispatchers.IO) {
if (notes.isEmpty() || !MarkdownParser.containsMarkdown(notes)) {
return@launch
}
val parsedNotes = MarkdownParser.parseMarkdown(notes)
if (existingMarkdownNotes != null && existingMarkdownNotes == parsedNotes) {
return@launch
}
existingMarkdownNotes = parsedNotes
withContext(Dispatchers.Main) {
data.parsedNotes = parsedNotes
notesTextView?.setParsedMarkdown(parsedNotes)