From 216b057fc46f99a92a7e56d58180eea3beb59400 Mon Sep 17 00:00:00 2001 From: Phillip Thelen Date: Sat, 24 Aug 2019 12:33:14 +0200 Subject: [PATCH] Fix various linting errors --- .../res/anim/button_state_list_animator.xml | 52 --- Habitica/res/anim/clockwise_rotate.xml | 8 - Habitica/res/anim/fab_slide_in.xml | 7 - Habitica/res/anim/fab_slide_out.xml | 7 - Habitica/res/anim/rotate_45_degrees.xml | 7 - Habitica/res/drawable/checklist_checked.xml | 2 +- Habitica/res/drawable/daily_checked.xml | 2 +- Habitica/res/drawable/todo_checked.xml | 2 +- Habitica/res/layout/achievement_list_item.xml | 4 +- Habitica/res/layout/activity_about.xml | 1 - .../res/layout/activity_challenge_detail.xml | 194 --------- .../res/layout/activity_class_selection.xml | 4 +- .../res/layout/activity_create_challenge.xml | 6 +- Habitica/res/layout/activity_fixcharacter.xml | 1 - Habitica/res/layout/activity_full_profile.xml | 6 +- Habitica/res/layout/activity_gem_purchase.xml | 6 +- Habitica/res/layout/activity_gift_iap.xml | 3 +- Habitica/res/layout/activity_intro.xml | 4 - Habitica/res/layout/activity_login.xml | 7 +- Habitica/res/layout/activity_main.xml | 1 - .../res/layout/activity_notifications.xml | 3 +- Habitica/res/layout/activity_party_invite.xml | 3 +- .../res/layout/activity_report_message.xml | 4 +- Habitica/res/layout/avatar_with_bars.xml | 6 +- Habitica/res/layout/challenge_item.xml | 2 - Habitica/res/layout/checklist_item.xml | 28 -- Habitica/res/layout/checklist_item_row.xml | 3 +- .../res/layout/custom_date_time_dialogue.xml | 28 -- .../res/layout/custom_list_preference_row.xml | 26 -- Habitica/res/layout/daily_item_card.xml | 1 - .../res/layout/dialog_achievement_details.xml | 7 +- .../res/layout/dialog_challenge_detail.xml | 213 --------- .../dialog_challenge_filter_group_item.xml | 2 +- Habitica/res/layout/dialog_faint.xml | 4 +- Habitica/res/layout/dialog_levelup.xml | 1 - .../layout/dialog_purchase_content_gear.xml | 16 +- .../layout/dialog_purchase_content_quest.xml | 1 - .../res/layout/dialog_purchase_shopitem.xml | 6 - Habitica/res/layout/dialog_task_filter.xml | 6 +- Habitica/res/layout/drawer_main.xml | 33 +- Habitica/res/layout/fixvalues_edittext.xml | 7 +- Habitica/res/layout/fragment_about.xml | 24 +- .../res/layout/fragment_avatar_overview.xml | 1 - .../res/layout/fragment_challenge_detail.xml | 1 - .../res/layout/fragment_fading_viewpager.xml | 5 - Habitica/res/layout/fragment_gem_purchase.xml | 6 +- Habitica/res/layout/fragment_guild_detail.xml | 6 +- Habitica/res/layout/fragment_party_detail.xml | 8 +- Habitica/res/layout/fragment_recyclerview.xml | 1 - .../layout/fragment_refresh_recyclerview.xml | 1 - Habitica/res/layout/fragment_shop.xml | 38 -- Habitica/res/layout/fragment_subscription.xml | 2 - .../res/layout/fragment_tavern_detail.xml | 1 - Habitica/res/layout/fragment_welcome.xml | 2 +- Habitica/res/layout/item_inbox_overview.xml | 3 +- Habitica/res/layout/no_notifications.xml | 4 +- .../res/layout/normal_list_preference_row.xml | 39 -- .../layout/notification_item_actionable.xml | 1 - Habitica/res/layout/notifications_header.xml | 2 +- Habitica/res/layout/party_member_quest.xml | 31 -- .../layout/preference_child_summary_error.xml | 3 +- .../res/layout/profile_achievement_item.xml | 3 +- Habitica/res/layout/qr_code.xml | 60 --- Habitica/res/layout/qr_dialogue.xml | 19 - Habitica/res/layout/refresh_actionview.xml | 6 - Habitica/res/layout/reminder_item.xml | 24 - Habitica/res/layout/reward_item_card.xml | 3 - Habitica/res/layout/row_checklist.xml | 10 - Habitica/res/layout/row_number_picker.xml | 27 -- Habitica/res/layout/shop_header.xml | 7 +- Habitica/res/layout/simple_widget.xml | 90 ---- Habitica/res/layout/skill_task_item_card.xml | 1 - .../res/layout/task_form_task_scheduling.xml | 9 +- Habitica/res/layout/tasks_duedate.xml | 36 -- Habitica/res/layout/tasks_startdate.xml | 23 - .../res/layout/tavern_chat_new_entry_item.xml | 3 +- Habitica/res/layout/value_bar.xml | 3 +- .../res/layout/view_collapsible_section.xml | 4 +- Habitica/res/layout/widget_avatar_stats.xml | 6 - .../layout/world_boss_description_view.xml | 8 +- Habitica/res/menu/challenge_admin.xml | 8 - Habitica/res/menu/chat_message.xml | 27 -- Habitica/res/menu/inbox.xml | 10 - Habitica/res/menu/login.xml | 11 - Habitica/res/menu/main_menu_tasks.xml | 18 - Habitica/res/values-bg/strings.profile.xml | 3 - Habitica/res/values-bg/strings.sidebar.xml | 31 +- Habitica/res/values-bg/strings.tutorial.xml | 8 +- Habitica/res/values-bg/strings.xml | 407 ++++++----------- Habitica/res/values-de/strings.profile.xml | 3 - Habitica/res/values-de/strings.sidebar.xml | 31 +- Habitica/res/values-de/strings.tutorial.xml | 8 +- Habitica/res/values-de/strings.xml | 391 ++++++----------- .../res/values-en-rGB/strings.profile.xml | 3 - .../res/values-en-rGB/strings.sidebar.xml | 31 +- .../res/values-en-rGB/strings.tutorial.xml | 8 +- Habitica/res/values-en-rGB/strings.xml | 260 +++-------- Habitica/res/values-es/strings.profile.xml | 3 - Habitica/res/values-es/strings.sidebar.xml | 31 +- Habitica/res/values-es/strings.tutorial.xml | 8 +- Habitica/res/values-es/strings.xml | 405 ++++++----------- Habitica/res/values-fr/strings.profile.xml | 3 - Habitica/res/values-fr/strings.sidebar.xml | 31 +- Habitica/res/values-fr/strings.tutorial.xml | 8 +- Habitica/res/values-fr/strings.xml | 409 ++++++----------- .../res/values-hr-rHR/strings.profile.xml | 3 - .../res/values-hr-rHR/strings.sidebar.xml | 31 +- .../res/values-hr-rHR/strings.tutorial.xml | 8 +- Habitica/res/values-hr-rHR/strings.xml | 369 +++++----------- Habitica/res/values-in/strings.sidebar.xml | 31 +- Habitica/res/values-in/strings.tutorial.xml | 8 +- Habitica/res/values-in/strings.xml | 262 +++-------- Habitica/res/values-it/strings.profile.xml | 3 - Habitica/res/values-it/strings.sidebar.xml | 31 +- Habitica/res/values-it/strings.tutorial.xml | 8 +- Habitica/res/values-it/strings.xml | 393 ++++++----------- Habitica/res/values-iw/strings.sidebar.xml | 31 +- Habitica/res/values-iw/strings.tutorial.xml | 6 +- Habitica/res/values-iw/strings.xml | 206 +++------ Habitica/res/values-ja/strings.profile.xml | 3 - Habitica/res/values-ja/strings.sidebar.xml | 31 +- Habitica/res/values-ja/strings.tutorial.xml | 8 +- Habitica/res/values-ja/strings.xml | 410 ++++++----------- Habitica/res/values-ko/strings.profile.xml | 5 +- Habitica/res/values-ko/strings.sidebar.xml | 31 +- Habitica/res/values-ko/strings.tutorial.xml | 8 +- Habitica/res/values-ko/strings.xml | 381 +++++----------- Habitica/res/values-land/bools.xml | 4 +- Habitica/res/values-land/dimens.xml | 6 +- Habitica/res/values-lt/strings.profile.xml | 3 - Habitica/res/values-lt/strings.sidebar.xml | 31 +- Habitica/res/values-lt/strings.tutorial.xml | 6 +- Habitica/res/values-lt/strings.xml | 272 ++++-------- Habitica/res/values-nl/strings.profile.xml | 3 - Habitica/res/values-nl/strings.sidebar.xml | 31 +- Habitica/res/values-nl/strings.tutorial.xml | 8 +- Habitica/res/values-nl/strings.xml | 405 ++++++----------- Habitica/res/values-pl/strings.profile.xml | 3 - Habitica/res/values-pl/strings.sidebar.xml | 31 +- Habitica/res/values-pl/strings.tutorial.xml | 8 +- Habitica/res/values-pl/strings.xml | 250 +++-------- .../res/values-pt-rBR/strings.profile.xml | 3 - .../res/values-pt-rBR/strings.sidebar.xml | 31 +- .../res/values-pt-rBR/strings.tutorial.xml | 10 +- Habitica/res/values-pt-rBR/strings.xml | 408 ++++++----------- .../res/values-pt-rPT/strings.profile.xml | 3 - .../res/values-pt-rPT/strings.sidebar.xml | 31 +- .../res/values-pt-rPT/strings.tutorial.xml | 8 +- Habitica/res/values-pt-rPT/strings.xml | 287 ++++-------- Habitica/res/values-ru/strings.profile.xml | 3 - Habitica/res/values-ru/strings.sidebar.xml | 31 +- Habitica/res/values-ru/strings.tutorial.xml | 8 +- Habitica/res/values-ru/strings.xml | 411 ++++++------------ Habitica/res/values-sw320dp/dimens.xml | 4 +- Habitica/res/values-tr/strings.profile.xml | 3 - Habitica/res/values-tr/strings.sidebar.xml | 31 +- Habitica/res/values-tr/strings.tutorial.xml | 8 +- Habitica/res/values-tr/strings.xml | 407 ++++++----------- Habitica/res/values-w360dp/styles.xml | 6 +- .../res/values-zh-rTW/strings.profile.xml | 3 - .../res/values-zh-rTW/strings.sidebar.xml | 31 +- .../res/values-zh-rTW/strings.tutorial.xml | 8 +- Habitica/res/values-zh-rTW/strings.xml | 393 +++++------------ Habitica/res/values-zh/strings.profile.xml | 3 - Habitica/res/values-zh/strings.sidebar.xml | 31 +- Habitica/res/values-zh/strings.tutorial.xml | 8 +- Habitica/res/values-zh/strings.xml | 408 ++++++----------- Habitica/res/values/bools.xml | 4 +- Habitica/res/values/colors.classes.xml | 7 +- Habitica/res/values/colors.contributor.xml | 2 - Habitica/res/values/colors.xml | 29 -- Habitica/res/values/dimens.xml | 35 -- Habitica/res/values/ids.xml | 5 +- Habitica/res/values/strings.constants.xml | 5 - Habitica/res/values/strings.profile.xml | 3 - Habitica/res/values/strings.sidebar.xml | 31 +- Habitica/res/values/strings.tutorial.xml | 4 - Habitica/res/values/strings.xml | 257 +++-------- Habitica/res/values/styles.challenges.xml | 22 - Habitica/res/values/styles.habitica.xml | 7 - Habitica/res/values/styles.xml | 84 ---- Habitica/res/values/values.xml | 25 -- Habitica/res/xml/add_task_widget_info.xml | 8 - Habitica/res/xml/main_menu_tasks.xml | 19 - .../habitica/HabiticaBaseApplication.kt | 5 +- .../habitica/HabiticaPurchaseVerifier.java | 2 +- .../habitica/helpers/TaskAlarmManager.kt | 4 +- .../receivers/NotificationPublisher.kt | 6 +- .../android/habitica/ui/RoundedFrameLayout.kt | 10 +- .../habitica/ui/activities/BaseActivity.kt | 2 +- .../habitica/ui/activities/MainActivity.kt | 2 +- .../habitica/ui/activities/SetupActivity.kt | 12 +- .../ui/views/HabiticaAutocompleteTextView.kt | 7 +- .../ui/views/HabiticaEmojiTextView.kt | 4 +- .../habitica/ui/views/stats/StatsView.kt | 9 +- .../habitica/widget/AddTaskWidgetProvider.kt | 2 +- .../android/sdk/ConnectionProcessor.java | 5 +- seeds-sdk/src/main/res/drawable/bar.png | Bin 2773 -> 0 bytes .../src/main/res/drawable/browser_back.png | Bin 1032 -> 0 bytes .../main/res/drawable/browser_external.png | Bin 1640 -> 0 bytes .../src/main/res/drawable/browser_forward.png | Bin 1024 -> 0 bytes .../src/main/res/drawable/browser_reload.png | Bin 2054 -> 0 bytes .../main/res/drawable/close_button_normal.png | Bin 4730 -> 0 bytes .../res/drawable/close_button_pressed.png | Bin 5091 -> 0 bytes seeds-sdk/src/main/res/drawable/skip.png | Bin 4152 -> 0 bytes .../src/main/res/drawable/video_pause.png | Bin 311 -> 0 bytes .../src/main/res/drawable/video_play.png | Bin 1024 -> 0 bytes .../src/main/res/drawable/video_replay.png | Bin 2054 -> 0 bytes 208 files changed, 2673 insertions(+), 7251 deletions(-) delete mode 100644 Habitica/res/anim/button_state_list_animator.xml delete mode 100644 Habitica/res/anim/clockwise_rotate.xml delete mode 100644 Habitica/res/anim/fab_slide_in.xml delete mode 100644 Habitica/res/anim/fab_slide_out.xml delete mode 100644 Habitica/res/anim/rotate_45_degrees.xml delete mode 100644 Habitica/res/layout/activity_challenge_detail.xml delete mode 100644 Habitica/res/layout/checklist_item.xml delete mode 100644 Habitica/res/layout/custom_date_time_dialogue.xml delete mode 100644 Habitica/res/layout/custom_list_preference_row.xml delete mode 100644 Habitica/res/layout/dialog_challenge_detail.xml delete mode 100644 Habitica/res/layout/dialog_purchase_shopitem.xml delete mode 100644 Habitica/res/layout/fragment_fading_viewpager.xml delete mode 100644 Habitica/res/layout/fragment_shop.xml delete mode 100644 Habitica/res/layout/normal_list_preference_row.xml delete mode 100644 Habitica/res/layout/party_member_quest.xml delete mode 100644 Habitica/res/layout/qr_code.xml delete mode 100644 Habitica/res/layout/qr_dialogue.xml delete mode 100644 Habitica/res/layout/refresh_actionview.xml delete mode 100644 Habitica/res/layout/reminder_item.xml delete mode 100644 Habitica/res/layout/row_checklist.xml delete mode 100644 Habitica/res/layout/row_number_picker.xml delete mode 100644 Habitica/res/layout/simple_widget.xml delete mode 100644 Habitica/res/layout/tasks_duedate.xml delete mode 100644 Habitica/res/layout/tasks_startdate.xml delete mode 100644 Habitica/res/menu/challenge_admin.xml delete mode 100644 Habitica/res/menu/chat_message.xml delete mode 100644 Habitica/res/menu/inbox.xml delete mode 100644 Habitica/res/menu/login.xml delete mode 100644 Habitica/res/menu/main_menu_tasks.xml delete mode 100644 Habitica/res/xml/add_task_widget_info.xml delete mode 100644 Habitica/res/xml/main_menu_tasks.xml delete mode 100755 seeds-sdk/src/main/res/drawable/bar.png delete mode 100755 seeds-sdk/src/main/res/drawable/browser_back.png delete mode 100755 seeds-sdk/src/main/res/drawable/browser_external.png delete mode 100755 seeds-sdk/src/main/res/drawable/browser_forward.png delete mode 100755 seeds-sdk/src/main/res/drawable/browser_reload.png delete mode 100755 seeds-sdk/src/main/res/drawable/close_button_normal.png delete mode 100755 seeds-sdk/src/main/res/drawable/close_button_pressed.png delete mode 100755 seeds-sdk/src/main/res/drawable/skip.png delete mode 100755 seeds-sdk/src/main/res/drawable/video_pause.png delete mode 100755 seeds-sdk/src/main/res/drawable/video_play.png delete mode 100755 seeds-sdk/src/main/res/drawable/video_replay.png diff --git a/Habitica/res/anim/button_state_list_animator.xml b/Habitica/res/anim/button_state_list_animator.xml deleted file mode 100644 index 50ed16c7d..000000000 --- a/Habitica/res/anim/button_state_list_animator.xml +++ /dev/null @@ -1,52 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/Habitica/res/anim/clockwise_rotate.xml b/Habitica/res/anim/clockwise_rotate.xml deleted file mode 100644 index 84c5476dc..000000000 --- a/Habitica/res/anim/clockwise_rotate.xml +++ /dev/null @@ -1,8 +0,0 @@ - - \ No newline at end of file diff --git a/Habitica/res/anim/fab_slide_in.xml b/Habitica/res/anim/fab_slide_in.xml deleted file mode 100644 index bac34df5b..000000000 --- a/Habitica/res/anim/fab_slide_in.xml +++ /dev/null @@ -1,7 +0,0 @@ - - - - \ No newline at end of file diff --git a/Habitica/res/anim/fab_slide_out.xml b/Habitica/res/anim/fab_slide_out.xml deleted file mode 100644 index 6d97fbbe2..000000000 --- a/Habitica/res/anim/fab_slide_out.xml +++ /dev/null @@ -1,7 +0,0 @@ - - - - \ No newline at end of file diff --git a/Habitica/res/anim/rotate_45_degrees.xml b/Habitica/res/anim/rotate_45_degrees.xml deleted file mode 100644 index b2cf69b8f..000000000 --- a/Habitica/res/anim/rotate_45_degrees.xml +++ /dev/null @@ -1,7 +0,0 @@ - - \ No newline at end of file diff --git a/Habitica/res/drawable/checklist_checked.xml b/Habitica/res/drawable/checklist_checked.xml index 7ab67c248..70d16bd6e 100644 --- a/Habitica/res/drawable/checklist_checked.xml +++ b/Habitica/res/drawable/checklist_checked.xml @@ -2,7 +2,7 @@ - + diff --git a/Habitica/res/drawable/daily_checked.xml b/Habitica/res/drawable/daily_checked.xml index 7ca5b679b..40e7e1787 100644 --- a/Habitica/res/drawable/daily_checked.xml +++ b/Habitica/res/drawable/daily_checked.xml @@ -2,7 +2,7 @@ - + diff --git a/Habitica/res/drawable/todo_checked.xml b/Habitica/res/drawable/todo_checked.xml index 415d4ba29..dba88c0e9 100644 --- a/Habitica/res/drawable/todo_checked.xml +++ b/Habitica/res/drawable/todo_checked.xml @@ -2,7 +2,7 @@ - + diff --git a/Habitica/res/layout/achievement_list_item.xml b/Habitica/res/layout/achievement_list_item.xml index def7138ec..4da888628 100644 --- a/Habitica/res/layout/achievement_list_item.xml +++ b/Habitica/res/layout/achievement_list_item.xml @@ -37,7 +37,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:layout_marginRight="@dimen/spacing_large"> + android:layout_marginEnd="@dimen/spacing_large"> - r + \ No newline at end of file diff --git a/Habitica/res/layout/activity_about.xml b/Habitica/res/layout/activity_about.xml index c07bcb736..0329f6e21 100644 --- a/Habitica/res/layout/activity_about.xml +++ b/Habitica/res/layout/activity_about.xml @@ -22,7 +22,6 @@ diff --git a/Habitica/res/layout/activity_challenge_detail.xml b/Habitica/res/layout/activity_challenge_detail.xml deleted file mode 100644 index 4470417ee..000000000 --- a/Habitica/res/layout/activity_challenge_detail.xml +++ /dev/null @@ -1,194 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - -