From 4756369b3ba2dadea289b247627c6f88d37c8271 Mon Sep 17 00:00:00 2001
From: Lula Villalobos <lulavillalobos@gmail.com>
Date: Fri, 27 Oct 2017 14:29:07 -0700
Subject: [PATCH] added new confirmation message for begin quest alert dialog

---
 Habitica/res/values/strings.xml                               | 2 ++
 .../habitica/ui/fragments/social/QuestDetailFragment.java     | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Habitica/res/values/strings.xml b/Habitica/res/values/strings.xml
index 3dc1248e0..58e85154a 100644
--- a/Habitica/res/values/strings.xml
+++ b/Habitica/res/values/strings.xml
@@ -300,6 +300,8 @@
     <string name="quest_cancel_message">Are you sure you want to cancel this quest? All invitation acceptances will be lost. The quest owner will retain possession of the quest scroll.</string>
     <string name="quest.invitation">Quest Invitation</string>
     <string name="quest_begin_message">Are you sure you want to begin the quest? Once it is active, no additional party members can join the quest.</string>
+    <!--TODO quest_begin_message_2 for every translation-->
+    <string name="quest_begin_message_2">Are you sure? Only %1$d of your %2$d party members have joined this quest! Quests start automatically when all players have joined or rejected the invitation.</string>
     <string name="quest.invitation.text">You have been invited to participate in a quest!</string>
     <string name="ago_1day">1 day ago</string>
     <string name="ago_days" >%d days ago</string>
diff --git a/Habitica/src/main/java/com/habitrpg/android/habitica/ui/fragments/social/QuestDetailFragment.java b/Habitica/src/main/java/com/habitrpg/android/habitica/ui/fragments/social/QuestDetailFragment.java
index bab2f1926..e37dfefe3 100644
--- a/Habitica/src/main/java/com/habitrpg/android/habitica/ui/fragments/social/QuestDetailFragment.java
+++ b/Habitica/src/main/java/com/habitrpg/android/habitica/ui/fragments/social/QuestDetailFragment.java
@@ -81,6 +81,7 @@ public class QuestDetailFragment extends BaseMainFragment {
     public String questKey;
     private Group party;
     private Quest quest;
+    private String begin_quest_message;
 
 
     @Nullable
@@ -205,6 +206,7 @@ public class QuestDetailFragment extends BaseMainFragment {
         } else {
             participantHeader.setText(R.string.invitations);
             participantHeaderCount.setText(participantCount + "/" + quest.participants.size());
+            begin_quest_message = getString(R.string.quest_begin_message_2, participantCount, quest.participants.size());
         }
     }
 
@@ -230,7 +232,7 @@ public class QuestDetailFragment extends BaseMainFragment {
     @OnClick(R.id.quest_begin_button)
     public void onQuestBegin() {
         AlertDialog.Builder builder = new AlertDialog.Builder(getActivity())
-                .setMessage(R.string.quest_begin_message)
+                .setMessage(begin_quest_message)
                 .setPositiveButton(R.string.yes, (dialog, which) -> socialRepository.forceStartQuest(party)
                         .subscribe(quest -> {}, RxErrorHandler.handleEmptyError()))
                 .setNegativeButton(R.string.no, (dialog, which) -> {});