From 564ad8ecbeb3c9b102eeeaf8c0722522d60f24e4 Mon Sep 17 00:00:00 2001 From: Phillip Thelen Date: Thu, 17 Sep 2020 13:47:02 +0200 Subject: [PATCH] Improve RTL support --- .../res/drawable/adventure_guide_menu_bg.xml | 4 +- .../res/layout/achievement_section_header.xml | 4 +- .../res/layout/activity_create_challenge.xml | 8 +- Habitica/res/layout/activity_fixcharacter.xml | 24 +++--- .../res/layout/activity_gift_subscription.xml | 8 +- Habitica/res/layout/activity_group_form.xml | 16 ++-- Habitica/res/layout/activity_login.xml | 4 +- .../res/layout/activity_report_message.xml | 4 +- Habitica/res/layout/activity_setup.xml | 85 +++++++++---------- Habitica/res/layout/activity_task_form.xml | 4 +- .../res/layout/activity_verify_username.xml | 26 +++--- Habitica/res/layout/challenge_item.xml | 7 +- Habitica/res/layout/chat_bar_view.xml | 8 +- Habitica/res/layout/chat_item.xml | 4 +- .../layout/class_spinner_dropdown_item.xml | 6 +- .../class_spinner_dropdown_item_selected.xml | 2 +- Habitica/res/layout/daily_item_card.xml | 8 +- .../res/layout/dialog_achievement_details.xml | 4 +- .../layout/dialog_challenge_detail_daily.xml | 2 +- .../layout/dialog_challenge_detail_habit.xml | 4 +- .../dialog_challenge_detail_task_group.xml | 4 +- .../layout/dialog_challenge_detail_todo.xml | 2 +- .../res/layout/dialog_challenge_filter.xml | 10 +-- .../dialog_choose_message_recipient.xml | 4 +- .../layout/dialog_completed_quest_content.xml | 4 +- Habitica/res/layout/dialog_faint.xml | 8 +- .../res/layout/dialog_login_incentive.xml | 4 +- .../layout/dialog_purchase_content_gear.xml | 4 +- .../layout/dialog_purchase_content_item.xml | 4 +- .../layout/dialog_purchase_content_quest.xml | 24 +++--- Habitica/res/layout/dialog_purchase_gems.xml | 4 +- .../dialog_purchase_shopitem_button.xml | 4 +- .../dialog_purchase_shopitem_header.xml | 4 +- Habitica/res/layout/dialog_task_filter.xml | 4 +- Habitica/res/layout/drawer_main_item.xml | 4 +- .../res/layout/drawer_main_section_header.xml | 4 +- Habitica/res/layout/edit_tag_item.xml | 6 +- Habitica/res/layout/filter_menu_item.xml | 4 +- .../res/layout/fragment_avatar_overview.xml | 6 +- .../res/layout/fragment_challenge_detail.xml | 17 ++-- .../res/layout/fragment_challengeslist.xml | 4 +- Habitica/res/layout/fragment_gem_purchase.xml | 22 +++-- .../res/layout/fragment_gift_gem_balance.xml | 4 +- .../res/layout/fragment_gift_gem_purchase.xml | 4 +- Habitica/res/layout/fragment_guild_detail.xml | 16 ++-- Habitica/res/layout/fragment_no_party.xml | 8 +- Habitica/res/layout/fragment_party_invite.xml | 6 +- Habitica/res/layout/fragment_promo_info.xml | 4 +- Habitica/res/layout/fragment_quest_detail.xml | 14 +-- Habitica/res/layout/fragment_setup_avatar.xml | 4 +- Habitica/res/layout/fragment_setup_tasks.xml | 4 +- Habitica/res/layout/fragment_stats.xml | 16 ++-- Habitica/res/layout/fragment_subscription.xml | 12 +-- .../res/layout/fragment_support_bug_fix.xml | 12 +-- Habitica/res/layout/fragment_welcome.xml | 26 +++--- Habitica/res/layout/gear_list_item.xml | 18 ++-- Habitica/res/layout/habit_item_card.xml | 8 +- Habitica/res/layout/help_header.xml | 4 +- Habitica/res/layout/item_inbox_overview.xml | 3 +- Habitica/res/layout/item_item.xml | 2 +- Habitica/res/layout/no_notifications.xml | 8 +- Habitica/res/layout/notification_item.xml | 8 +- .../layout/notification_item_actionable.xml | 10 +-- Habitica/res/layout/notifications_header.xml | 4 +- Habitica/res/layout/overlay_tutorial.xml | 4 +- Habitica/res/layout/party_member.xml | 2 +- Habitica/res/layout/preference_category.xml | 4 +- .../res/layout/preference_child_summary.xml | 10 +-- .../layout/preference_child_summary_error.xml | 10 +-- .../layout/profile_achievement_category.xml | 4 +- .../res/layout/profile_achievement_item.xml | 4 +- Habitica/res/layout/quest_menu_view.xml | 22 ++--- Habitica/res/layout/quest_progress.xml | 42 ++++----- Habitica/res/layout/reward_item_card.xml | 8 +- Habitica/res/layout/row_quest_reward.xml | 4 +- .../res/layout/row_quest_reward_imageview.xml | 4 +- .../res/layout/setup_customization_item.xml | 6 +- Habitica/res/layout/shop_header.xml | 4 +- Habitica/res/layout/shop_section_header.xml | 4 +- Habitica/res/layout/skill_list_item.xml | 6 +- Habitica/res/layout/skill_task_item_card.xml | 6 +- Habitica/res/layout/snackbar_view.xml | 4 +- Habitica/res/layout/speechbubble.xml | 8 +- Habitica/res/layout/stats_view.xml | 8 +- Habitica/res/layout/support_faq_item.xml | 6 +- Habitica/res/layout/todo_item_card.xml | 8 +- .../res/layout/view_collapsible_section.xml | 4 +- .../res/layout/widget_dailies_list_row.xml | 2 - Habitica/res/layout/widget_habit_button.xml | 4 +- Habitica/res/layout/widget_task_list.xml | 4 +- Habitica/res/layout/widget_todo_list_row.xml | 2 - .../layout/world_boss_description_view.xml | 4 +- Habitica/res/values-v23/styles.xml | 4 +- Habitica/res/values/styles.xml | 44 +++++----- 94 files changed, 399 insertions(+), 425 deletions(-) diff --git a/Habitica/res/drawable/adventure_guide_menu_bg.xml b/Habitica/res/drawable/adventure_guide_menu_bg.xml index b5877fa91..7a696951d 100644 --- a/Habitica/res/drawable/adventure_guide_menu_bg.xml +++ b/Habitica/res/drawable/adventure_guide_menu_bg.xml @@ -8,12 +8,12 @@ \ No newline at end of file diff --git a/Habitica/res/layout/achievement_section_header.xml b/Habitica/res/layout/achievement_section_header.xml index a89675365..8f008a50d 100644 --- a/Habitica/res/layout/achievement_section_header.xml +++ b/Habitica/res/layout/achievement_section_header.xml @@ -6,8 +6,8 @@ android:layout_height="wrap_content" android:gravity="center_vertical" android:layout_marginTop="@dimen/spacing_medium" - android:paddingLeft="@dimen/spacing_large" - android:paddingRight="@dimen/spacing_large"> + android:paddingStart="@dimen/spacing_large" + android:paddingEnd="@dimen/spacing_large"> @@ -93,8 +93,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="vertical" - android:paddingLeft="@dimen/activity_horizontal_margin" - android:paddingRight="@dimen/activity_horizontal_margin"> + android:paddingStart="@dimen/activity_horizontal_margin" + android:paddingEnd="@dimen/activity_horizontal_margin"> + android:layout_marginStart="@dimen/spacing_large" + android:layout_marginEnd="@dimen/spacing_large"/> @@ -97,8 +97,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginTop="@dimen/spacing_large" - android:layout_marginLeft="@dimen/spacing_large" - android:layout_marginRight="@dimen/spacing_large"> + android:layout_marginStart="@dimen/spacing_large" + android:layout_marginEnd="@dimen/spacing_large"> diff --git a/Habitica/res/layout/activity_report_message.xml b/Habitica/res/layout/activity_report_message.xml index d2d6dfaab..e9d5f836c 100644 --- a/Habitica/res/layout/activity_report_message.xml +++ b/Habitica/res/layout/activity_report_message.xml @@ -77,8 +77,8 @@ android:orientation="vertical" android:layout_width="match_parent" android:layout_height="match_parent" android:paddingTop="16dp" - android:paddingLeft="24dp" - android:paddingRight="24dp" + android:paddingStart="24dp" + android:paddingEnd="24dp" android:paddingBottom="25dp" android:layout_marginBottom="0dp" android:focusableInTouchMode="true"> diff --git a/Habitica/res/layout/activity_setup.xml b/Habitica/res/layout/activity_setup.xml index 427c8a7dd..fff7eae37 100644 --- a/Habitica/res/layout/activity_setup.xml +++ b/Habitica/res/layout/activity_setup.xml @@ -1,57 +1,52 @@ + android:layout_width="match_parent" android:layout_height="match_parent"> + android:id="@+id/viewPager" + android:layout_width="match_parent" + android:layout_height="match_parent" + android:layout_above="@+id/bottomBar" /> - + android:id="@+id/bottomBar" + android:orientation="horizontal" + android:layout_width="match_parent" + android:layout_height="56dp" + android:layout_alignParentBottom="true" + android:layout_centerHorizontal="true" + android:layout_alignParentStart="true" + android:layout_alignParentEnd="true" + android:background="@color/brand_300" + android:paddingStart="@dimen/content_inset" + android:paddingEnd="@dimen/content_inset" + android:gravity="center_vertical" + android:elevation="8dp">