From 59b39772d3bf6c2d87969e6d74e4b7219bed7daa Mon Sep 17 00:00:00 2001 From: Angelo Viado Date: Sat, 9 Mar 2019 11:40:55 +0900 Subject: [PATCH] Fix notifications not showing Add channel when building notification for daily reminder Extend WakefulBroadcastReceiver instead of BroadcastReceiver Remove android:process=":remote" in the manifest Fixes #1105 --- Habitica/AndroidManifest.xml | 6 ++---- .../android/habitica/receivers/NotificationPublisher.kt | 6 +++--- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/Habitica/AndroidManifest.xml b/Habitica/AndroidManifest.xml index 8467ed430..15818d1c9 100644 --- a/Habitica/AndroidManifest.xml +++ b/Habitica/AndroidManifest.xml @@ -188,11 +188,9 @@ - + - + diff --git a/Habitica/src/main/java/com/habitrpg/android/habitica/receivers/NotificationPublisher.kt b/Habitica/src/main/java/com/habitrpg/android/habitica/receivers/NotificationPublisher.kt index 86afeda9a..d3cc56c94 100644 --- a/Habitica/src/main/java/com/habitrpg/android/habitica/receivers/NotificationPublisher.kt +++ b/Habitica/src/main/java/com/habitrpg/android/habitica/receivers/NotificationPublisher.kt @@ -3,6 +3,7 @@ package com.habitrpg.android.habitica.receivers import android.app.Notification import android.app.NotificationManager import android.app.PendingIntent +import android.content.BroadcastReceiver import android.content.Context import android.content.Intent import android.content.SharedPreferences @@ -10,7 +11,6 @@ import android.os.Build import androidx.core.app.NotificationCompat import androidx.core.content.ContextCompat import androidx.core.content.edit -import androidx.legacy.content.WakefulBroadcastReceiver import com.habitrpg.android.habitica.HabiticaBaseApplication import com.habitrpg.android.habitica.R import com.habitrpg.android.habitica.data.TaskRepository @@ -31,7 +31,7 @@ import javax.inject.Inject @Suppress("DEPRECATION") //https://gist.github.com/BrandonSmith/6679223 -class NotificationPublisher : WakefulBroadcastReceiver() { +class NotificationPublisher : BroadcastReceiver() { @Inject lateinit var taskRepository: TaskRepository @@ -96,7 +96,7 @@ class NotificationPublisher : WakefulBroadcastReceiver() { private fun buildNotification(wasInactive: Boolean, registrationDate: Date? = null): Notification? { val thisContext = context ?: return null val notification: Notification - val builder = NotificationCompat.Builder(thisContext) + val builder = NotificationCompat.Builder(thisContext, "default") builder.setContentTitle(thisContext.getString(R.string.reminder_title)) var notificationText = getRandomDailyTip() if (registrationDate != null) {