From 40dcbe44e6ece70cd3e53ef01169c799bdfcb922 Mon Sep 17 00:00:00 2001 From: Phillip Thelen Date: Fri, 4 Dec 2015 16:36:05 +0100 Subject: [PATCH 1/3] fix potential crash when loading tasks fragment --- .../android/habitica/ui/fragments/TasksFragment.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Habitica/src/com/habitrpg/android/habitica/ui/fragments/TasksFragment.java b/Habitica/src/com/habitrpg/android/habitica/ui/fragments/TasksFragment.java index 4a81d2aeb..da12b8c34 100644 --- a/Habitica/src/com/habitrpg/android/habitica/ui/fragments/TasksFragment.java +++ b/Habitica/src/com/habitrpg/android/habitica/ui/fragments/TasksFragment.java @@ -322,9 +322,9 @@ public class TasksFragment extends BaseFragment implements TaskScoringCallback.O } }); - - tabLayout.setupWithViewPager(viewPager); - + if (tabLayout != null) { + tabLayout.setupWithViewPager(viewPager); + } } public void updateUserData(HabitRPGUser user) { From f3ecc216611bdf9172ffb00970170b10e9388742 Mon Sep 17 00:00:00 2001 From: Phillip Thelen Date: Sat, 5 Dec 2015 15:10:11 +0100 Subject: [PATCH 2/3] Tease upcoming features in sidebar. Fixes #105 --- Habitica/res/values/strings.xml | 1 + .../android/habitica/ui/MainDrawerBuilder.java | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Habitica/res/values/strings.xml b/Habitica/res/values/strings.xml index 4ef6b383b..dce067e6b 100644 --- a/Habitica/res/values/strings.xml +++ b/Habitica/res/values/strings.xml @@ -193,4 +193,5 @@ Remember to check off your Dailies! Using Skill + Coming Soon \ No newline at end of file diff --git a/Habitica/src/com/habitrpg/android/habitica/ui/MainDrawerBuilder.java b/Habitica/src/com/habitrpg/android/habitica/ui/MainDrawerBuilder.java index 189e0fbdd..489e923d2 100644 --- a/Habitica/src/com/habitrpg/android/habitica/ui/MainDrawerBuilder.java +++ b/Habitica/src/com/habitrpg/android/habitica/ui/MainDrawerBuilder.java @@ -79,12 +79,12 @@ public class MainDrawerBuilder { new PrimaryDrawerItem().withName(activity.getString(R.string.sidebar_tavern)).withIdentifier(SIDEBAR_TAVERN), new PrimaryDrawerItem().withName(activity.getString(R.string.sidebar_party)).withIdentifier(SIDEBAR_PARTY), /*new PrimaryDrawerItem().withName(activity.getString(R.string.sidebar_guilds)), - new PrimaryDrawerItem().withName(activity.getString(R.string.sidebar_challenges)), + new PrimaryDrawerItem().withName(activity.getString(R.string.sidebar_challenges)),*/ new SectionDrawerItem().withName(activity.getString(R.string.sidebar_section_inventory)), - new PrimaryDrawerItem().withName(activity.getString(R.string.sidebar_avatar)), - new PrimaryDrawerItem().withName(activity.getString(R.string.sidebar_equipment)), - new PrimaryDrawerItem().withName(activity.getString(R.string.sidebar_stable)),*/ + new PrimaryDrawerItem().withName(activity.getString(R.string.sidebar_avatar)).withEnabled(false).withBadge(R.string.coming_soon), + new PrimaryDrawerItem().withName(activity.getString(R.string.sidebar_equipment)).withEnabled(false).withBadge(R.string.coming_soon), + new PrimaryDrawerItem().withName(activity.getString(R.string.sidebar_stable)).withEnabled(false).withBadge(R.string.coming_soon), new PrimaryDrawerItem().withName(activity.getString(R.string.sidebar_purchaseGems)).withIdentifier(SIDEBAR_PURCHASE), new DividerDrawerItem(), @@ -117,7 +117,7 @@ public class MainDrawerBuilder { fragment = new TavernFragment(); break; } - case SIDEBAR_PURCHASE:{ + case SIDEBAR_PURCHASE: { fragment = new GemsPurchaseFragment(); break; } From dd99bbe3ba1111aa464c8d0dedf8e011a0642711 Mon Sep 17 00:00:00 2001 From: Phillip Thelen Date: Sat, 5 Dec 2015 16:12:01 +0100 Subject: [PATCH 3/3] Improve reward list handling. Fixes #103 --- Habitica/res/layout/reward_item_card.xml | 33 +++++++++++-------- .../adapter/HabitItemRecyclerViewAdapter.java | 6 +++- .../ui/fragments/PreferencesFragment.java | 2 +- 3 files changed, 26 insertions(+), 15 deletions(-) diff --git a/Habitica/res/layout/reward_item_card.xml b/Habitica/res/layout/reward_item_card.xml index c93ff8dd2..2070449f6 100644 --- a/Habitica/res/layout/reward_item_card.xml +++ b/Habitica/res/layout/reward_item_card.xml @@ -20,7 +20,7 @@ android:clickable="false" > - + bind:imageName='@{"shop_"+reward.id}' + android:layout_centerVertical="true" + android:layout_alignParentLeft="true" + android:layout_alignParentStart="true" /> + android:paddingRight="@dimen/reward_spacing" + android:layout_toLeftOf="@+id/btnReward" + android:layout_toRightOf="@+id/imageView3" + android:layout_toEndOf="@+id/imageView3"> @@ -65,20 +70,22 @@