From 67a0deee6126ac9806895a1f92e5609ac081b118 Mon Sep 17 00:00:00 2001 From: Phillip Thelen Date: Wed, 1 Feb 2017 16:58:53 +0100 Subject: [PATCH] fix a bunch of linter errors --- .tx/config | 2 +- Habitica/build.gradle | 3 +- Habitica/res/layout/activity_full_profile.xml | 4 +- .../res/layout/dialog_challenge_detail.xml | 4 +- .../layout/dialog_challenge_detail_daily.xml | 13 +- .../layout/dialog_challenge_detail_habit.xml | 13 +- .../layout/dialog_challenge_detail_reward.xml | 21 +- .../layout/dialog_challenge_detail_todo.xml | 13 +- .../dialog_choose_message_recipient.xml | 3 +- Habitica/res/layout/dialog_edit_tag.xml | 3 +- .../layout/edit_tags_section_drawer_item.xml | 4 +- Habitica/res/layout/fragment_about.xml | 1 - .../material_drawer_item_section_icon.xml | 16 +- .../res/layout/profile_achievement_item.xml | 17 +- Habitica/res/layout/qr_code.xml | 3 +- Habitica/res/layout/qr_dialogue.xml | 3 +- Habitica/res/layout/tavern_chat_item.xml | 8 +- Habitica/res/layout/widget_add_task.xml | 1 - Habitica/res/values-bg/strings.xml | 137 ++++-- Habitica/res/values-de/strings.xml | 118 +++-- Habitica/res/values-en-rGB/strings.xml | 137 ++++-- Habitica/res/values-es/strings.xml | 64 +-- Habitica/res/values-fr/strings.xml | 137 ++++-- Habitica/res/values-he/strings.profile.xml | 13 - Habitica/res/values-he/strings.sidebar.xml | 20 - Habitica/res/values-he/strings.tutorial.xml | 14 - Habitica/res/values-he/strings.xml | 369 --------------- Habitica/res/values-hr-rHR/strings.xml | 50 +-- Habitica/res/values-id/strings.profile.xml | 17 - Habitica/res/values-id/strings.sidebar.xml | 20 - Habitica/res/values-id/strings.tutorial.xml | 14 - Habitica/res/values-id/strings.xml | 419 ------------------ Habitica/res/values-in/strings.sidebar.xml | 3 +- Habitica/res/values-in/strings.xml | 158 +++++-- Habitica/res/values-it/strings.xml | 138 ++++-- Habitica/res/values-iw/strings.sidebar.xml | 1 + Habitica/res/values-iw/strings.xml | 104 +++-- Habitica/res/values-ja/strings.profile.xml | 5 +- Habitica/res/values-ja/strings.xml | 86 ++-- Habitica/res/values-ko/strings.xml | 64 +-- Habitica/res/values-lt/strings.xml | 62 +-- Habitica/res/values-nl/strings.xml | 137 ++++-- Habitica/res/values-pl/strings.xml | 109 +++-- Habitica/res/values-pt-rBR/strings.xml | 98 ++-- .../res/values-pt-rPT/strings.profile.xml | 5 +- .../res/values-pt-rPT/strings.tutorial.xml | 2 +- Habitica/res/values-pt-rPT/strings.xml | 94 ++-- Habitica/res/values-ru/strings.xml | 125 ++++-- Habitica/res/values-tr/strings.profile.xml | 2 +- Habitica/res/values-tr/strings.tutorial.xml | 18 +- Habitica/res/values-tr/strings.xml | 92 ++-- Habitica/res/values-zh-rTW/strings.xml | 58 +-- Habitica/res/values-zh/strings.profile.xml | 5 +- Habitica/res/values-zh/strings.xml | 134 ++++-- Habitica/res/values/strings.sidebar.xml | 2 +- Habitica/res/values/strings.xml | 84 ++-- .../PushNotificationManager.java | 30 +- .../habitica/prefs/CustomListPreference.java | 219 --------- .../habitica/ui/activities/MainActivity.java | 4 +- .../habitica/ui/activities/SetupActivity.java | 2 +- .../CustomizationRecyclerViewAdapter.java | 4 +- .../setup/CustomizationSetupAdapter.java | 6 +- translations/store_strings-tr.xml | 2 +- 63 files changed, 1632 insertions(+), 1882 deletions(-) delete mode 100644 Habitica/res/values-he/strings.profile.xml delete mode 100644 Habitica/res/values-he/strings.sidebar.xml delete mode 100644 Habitica/res/values-he/strings.tutorial.xml delete mode 100644 Habitica/res/values-he/strings.xml delete mode 100644 Habitica/res/values-id/strings.profile.xml delete mode 100644 Habitica/res/values-id/strings.sidebar.xml delete mode 100644 Habitica/res/values-id/strings.tutorial.xml delete mode 100644 Habitica/res/values-id/strings.xml delete mode 100644 Habitica/src/main/java/com/habitrpg/android/habitica/prefs/CustomListPreference.java diff --git a/.tx/config b/.tx/config index a3df04c4e..69b82749a 100644 --- a/.tx/config +++ b/.tx/config @@ -1,6 +1,6 @@ [main] host = https://www.transifex.com -lang_map = pt_BR: pt-rBR, zh_TW: zh-rTW, hr_HR: hr-rHR, pt_PT: pt-rPT, en_GB: en-rGB +lang_map = pt_BR: pt-rBR, zh_TW: zh-rTW, hr_HR: hr-rHR, pt_PT: pt-rPT, en_GB: en-rGB, he: iw, id: in [habitica-android.store_stringsxml] file_filter = translations/store_strings-.xml diff --git a/Habitica/build.gradle b/Habitica/build.gradle index 2fca32fe2..29e3ab6e5 100644 --- a/Habitica/build.gradle +++ b/Habitica/build.gradle @@ -208,7 +208,8 @@ android { } lintOptions { - disable 'UnusedResources' + disable 'UnusedResources','MissingTranslation','UnusedAttribute','InvalidPackage' + enable 'LogConditional','IconExpectedSize','MissingRegistered','TypographyQuotes' } } diff --git a/Habitica/res/layout/activity_full_profile.xml b/Habitica/res/layout/activity_full_profile.xml index ffd566b61..5846402b9 100644 --- a/Habitica/res/layout/activity_full_profile.xml +++ b/Habitica/res/layout/activity_full_profile.xml @@ -9,7 +9,7 @@ diff --git a/Habitica/res/layout/dialog_challenge_detail.xml b/Habitica/res/layout/dialog_challenge_detail.xml index 90d22542c..ab70fcc7a 100644 --- a/Habitica/res/layout/dialog_challenge_detail.xml +++ b/Habitica/res/layout/dialog_challenge_detail.xml @@ -70,7 +70,7 @@ @@ -138,7 +138,7 @@ android:orientation="horizontal"> + xmlns:tools="http://schemas.android.com/tools" + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:background="@drawable/border_1f000000" + android:orientation="horizontal" + android:weightSum="3" + android:baselineAligned="false"> + xmlns:tools="http://schemas.android.com/tools" + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:orientation="horizontal" + android:background="@drawable/border_1f000000" + android:weightSum="3" + android:baselineAligned="false"> + xmlns:tools="http://schemas.android.com/tools" + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:orientation="horizontal" + android:background="@drawable/border_1f000000" + android:weightSum="3" + android:baselineAligned="false"> - - - - - - \ No newline at end of file diff --git a/Habitica/res/layout/dialog_challenge_detail_todo.xml b/Habitica/res/layout/dialog_challenge_detail_todo.xml index 5fc9d7fa3..402ded014 100644 --- a/Habitica/res/layout/dialog_challenge_detail_todo.xml +++ b/Habitica/res/layout/dialog_challenge_detail_todo.xml @@ -1,11 +1,12 @@ + xmlns:tools="http://schemas.android.com/tools" + android:layout_width="match_parent" + android:layout_height="wrap_content" + android:background="@drawable/border_1f000000" + android:orientation="horizontal" + android:weightSum="3" + android:baselineAligned="false"> + android:focusable="true" + android:maxLines="1"/>