sudoxreboot/habitica-android
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica-android.git synced 2026-05-21 05:09:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Handle failed response (404) gracefully for edge case

Browse source
This commit is contained in:
Hafizzle 2023-09-04 10:48:08 -04:00 committed by Phillip Thelen
parent 8efe33459b
commit 70dbc7b7c6
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Habitica/src/main/java/com/habitrpg/android/habitica/data/implementation/ApiClientImpl.kt
View file

@ -148,9 +148,18 @@ class ApiClientImpl(
} else {
// Modify cache control for 4xx or 5xx range - effectively "do not cache", preventing caching of 4xx and 5xx responses
if (response.code in 400..599) {
return@addNetworkInterceptor response.newBuilder()
.header("Cache-Control", "no-store")
.build()
when (response.code) {
404 -> {
// The server is returning a 404 error, which means the requested resource was not found.
// In this case - we want to actually cache the response, and handle it in the app
// to prevent a niche HttpException/potential network crash
return@addNetworkInterceptor response
}
else -> {
return@addNetworkInterceptor response.newBuilder().header("Cache-Control", "no-store").build()
}
}
} else {
return@addNetworkInterceptor response
}