From 84cb69d170d3511f2da9d00b55cf9a0838cfb488 Mon Sep 17 00:00:00 2001 From: Dan Lew Date: Fri, 18 Dec 2015 06:35:16 -0600 Subject: [PATCH] Fixed up logging of Exceptions Added stack traces to the logs, which helps for debugging. --- .../com/habitrpg/android/habitica/HabiticaApplication.java | 6 +++--- .../src/com/habitrpg/android/habitica/LoginActivity.java | 4 ++-- .../android/habitica/callbacks/TaskCreationCallback.java | 5 +---- .../android/habitica/callbacks/TaskDeletionCallback.java | 5 +---- .../android/habitica/callbacks/TaskScoringCallback.java | 5 +---- .../android/habitica/callbacks/TaskUpdateCallback.java | 5 +---- .../android/habitica/prefs/scanner/IntentIntegrator.java | 2 +- 7 files changed, 10 insertions(+), 22 deletions(-) diff --git a/Habitica/src/com/habitrpg/android/habitica/HabiticaApplication.java b/Habitica/src/com/habitrpg/android/habitica/HabiticaApplication.java index 8310ba99b..d08c50e7c 100644 --- a/Habitica/src/com/habitrpg/android/habitica/HabiticaApplication.java +++ b/Habitica/src/com/habitrpg/android/habitica/HabiticaApplication.java @@ -150,9 +150,9 @@ public class HabiticaApplication extends Application { Field field = FlowManager.class.getDeclaredField("mDatabaseHolder"); setFinalStatic(field, null); } catch (NoSuchFieldException noSuchField) { - Log.e("nosuchfield", "No such field exists in FlowManager"); + Log.e("nosuchfield", "No such field exists in FlowManager", noSuchField); } catch (IllegalAccessException illegalAccess) { - Log.e("illegalaccess", "Illegal access of FlowManager"); + Log.e("illegalaccess", "Illegal access of FlowManager", illegalAccess); } FlowManager.init(context); @@ -172,7 +172,7 @@ public class HabiticaApplication extends Application { File dbFile = context.getDatabasePath(databaseName); return dbFile.exists(); } catch (Exception exception) { - Log.e(exception.toString(), "Database %s doesn't exist."); + Log.e("DbExists", "Database %s doesn't exist.", exception); return false; } } diff --git a/Habitica/src/com/habitrpg/android/habitica/LoginActivity.java b/Habitica/src/com/habitrpg/android/habitica/LoginActivity.java index 8d598f6a9..20f19ddea 100644 --- a/Habitica/src/com/habitrpg/android/habitica/LoginActivity.java +++ b/Habitica/src/com/habitrpg/android/habitica/LoginActivity.java @@ -115,7 +115,7 @@ public class LoginActivity extends AppCompatActivity @Override public void onError(FacebookException exception) { - Log.d("FB Login", "Error"); + Log.e("FB Login", "Error", exception); } }); @@ -230,7 +230,7 @@ public class LoginActivity extends AppCompatActivity Log.d("scanresult", scanResult.getContents()); this.parse(scanResult.getContents()); } catch(Exception e) { - + Log.e("scanresult", "Could not parse scanResult", e); } } } diff --git a/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskCreationCallback.java b/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskCreationCallback.java index 7d6a10702..c3295bc71 100644 --- a/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskCreationCallback.java +++ b/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskCreationCallback.java @@ -1,11 +1,8 @@ package com.habitrpg.android.habitica.callbacks; import android.util.Log; - -import com.crashlytics.android.Crashlytics; import com.habitrpg.android.habitica.events.TaskCreatedEvent; import com.magicmicky.habitrpgwrapper.lib.models.tasks.Task; - import de.greenrobot.event.EventBus; import retrofit.Callback; import retrofit.RetrofitError; @@ -23,6 +20,6 @@ public class TaskCreationCallback implements Callback { @Override public void failure(RetrofitError error) { - Log.w("HabitCreation", "Error " + error.getMessage()); + Log.w("HabitCreation", "Error", error); } } diff --git a/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskDeletionCallback.java b/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskDeletionCallback.java index 262a76505..d456c4a6f 100644 --- a/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskDeletionCallback.java +++ b/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskDeletionCallback.java @@ -1,10 +1,7 @@ package com.habitrpg.android.habitica.callbacks; import android.util.Log; - -import com.crashlytics.android.Crashlytics; import com.magicmicky.habitrpgwrapper.lib.models.tasks.Task; - import retrofit.Callback; import retrofit.RetrofitError; import retrofit.client.Response; @@ -29,7 +26,7 @@ public class TaskDeletionCallback implements Callback { @Override public void failure(RetrofitError error) { callback.onTaskDeletionFail(); - Log.w("HabitDeletion", "Error " + error.getMessage()); + Log.w("HabitDeletion", "Error", error); } diff --git a/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskScoringCallback.java b/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskScoringCallback.java index b9a6863ba..31984522d 100644 --- a/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskScoringCallback.java +++ b/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskScoringCallback.java @@ -1,15 +1,12 @@ package com.habitrpg.android.habitica.callbacks; import android.util.Log; - -import com.crashlytics.android.Crashlytics; import com.magicmicky.habitrpgwrapper.lib.models.TaskDirectionData; import com.magicmicky.habitrpgwrapper.lib.models.tasks.Task; import com.raizlabs.android.dbflow.runtime.transaction.BaseTransaction; import com.raizlabs.android.dbflow.runtime.transaction.TransactionListener; import com.raizlabs.android.dbflow.sql.builder.Condition; import com.raizlabs.android.dbflow.sql.language.Select; - import retrofit.Callback; import retrofit.RetrofitError; import retrofit.client.Response; @@ -57,7 +54,7 @@ public class TaskScoringCallback implements Callback { @Override public void failure(RetrofitError error) { this.mCallback.onTaskScoringFailed(); - Log.w("TaskScoring", "Task scoring failed " + error.getMessage()); + Log.w("TaskScoring", "Task scoring failed", error); } public interface OnTaskScored { diff --git a/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskUpdateCallback.java b/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskUpdateCallback.java index 59e6743f6..4338db77d 100644 --- a/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskUpdateCallback.java +++ b/Habitica/src/com/habitrpg/android/habitica/callbacks/TaskUpdateCallback.java @@ -1,11 +1,8 @@ package com.habitrpg.android.habitica.callbacks; import android.util.Log; - -import com.crashlytics.android.Crashlytics; import com.habitrpg.android.habitica.events.TaskUpdatedEvent; import com.magicmicky.habitrpgwrapper.lib.models.tasks.Task; - import de.greenrobot.event.EventBus; import retrofit.Callback; import retrofit.RetrofitError; @@ -25,7 +22,7 @@ public class TaskUpdateCallback implements Callback { @Override public void failure(RetrofitError error) { - Log.w("HabitUpdate", "Error " + error.getMessage()); + Log.w("HabitUpdate", "Error", error); } } diff --git a/Habitica/src/com/habitrpg/android/habitica/prefs/scanner/IntentIntegrator.java b/Habitica/src/com/habitrpg/android/habitica/prefs/scanner/IntentIntegrator.java index 31948e542..579357176 100644 --- a/Habitica/src/com/habitrpg/android/habitica/prefs/scanner/IntentIntegrator.java +++ b/Habitica/src/com/habitrpg/android/habitica/prefs/scanner/IntentIntegrator.java @@ -313,7 +313,7 @@ public class IntentIntegrator { activity.startActivity(intent); } catch (ActivityNotFoundException anfe) { // Hmm, market is not installed - Log.w(TAG, "Google Play is not installed; cannot install " + packageName); + Log.w(TAG, "Google Play is not installed; cannot install " + packageName, anfe); } } });