From 944493652ea6b7820c40ea12464250bba9e82265 Mon Sep 17 00:00:00 2001 From: Leland Wu Date: Sat, 21 Mar 2020 14:45:22 -0400 Subject: [PATCH] fix crash happening in pets & mounts (#1275) * create binding variable to make consistent with Customization section view holder in stablerecycleradapter * remove comment --- .../android/habitica/ui/viewHolders/SectionViewHolder.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Habitica/src/main/java/com/habitrpg/android/habitica/ui/viewHolders/SectionViewHolder.kt b/Habitica/src/main/java/com/habitrpg/android/habitica/ui/viewHolders/SectionViewHolder.kt index 9a74a2b70..b05085a9a 100644 --- a/Habitica/src/main/java/com/habitrpg/android/habitica/ui/viewHolders/SectionViewHolder.kt +++ b/Habitica/src/main/java/com/habitrpg/android/habitica/ui/viewHolders/SectionViewHolder.kt @@ -9,12 +9,13 @@ import android.widget.Button import android.widget.Spinner import android.widget.TextView import com.habitrpg.android.habitica.R +import com.habitrpg.android.habitica.databinding.CustomizationSectionHeaderBinding import com.habitrpg.android.habitica.ui.helpers.bindView class SectionViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) { + private val binding = CustomizationSectionHeaderBinding.bind(itemView) private val label: TextView by bindView(itemView, R.id.label) - private val purchaseSetButton: Button? by bindView(itemView, R.id.purchaseSetButton) private val selectionSpinner: Spinner? by bindView(itemView, R.id.classSelectionSpinner) internal val notesView: TextView? by bindView(itemView, R.id.headerNotesView) var context: Context = itemView.context @@ -22,7 +23,7 @@ class SectionViewHolder(itemView: View) : RecyclerView.ViewHolder(itemView) { var spinnerSelectionChanged: (() -> Unit)? = null init { - this.purchaseSetButton?.visibility = View.GONE + binding.purchaseSetButton.visibility = View.GONE selectionSpinner?.onItemSelectedListener = object: AdapterView.OnItemSelectedListener { override fun onNothingSelected(parent: AdapterView<*>?) { spinnerSelectionChanged?.invoke()