fix code issues

This commit is contained in:
Phillip Thelen 2021-04-07 13:09:42 +02:00
parent d3ae17f4ca
commit a238f8c1cb
4 changed files with 12 additions and 12 deletions

View file

@ -149,7 +149,7 @@ android {
buildConfigField "String", "TESTING_LEVEL", "\"production\""
resConfigs "en", "bg", "de", "en-rGB", "es", "fr", "hr-rHR", "in", "it", "iw", "ja", "ko", "lt", "nl", "pl", "pt-rBR", "pt-rPT", "ru", "tr", "zh", "zh-rTW"
versionCode 2895
versionCode 2903
versionName "3.2.2"
}

View file

@ -12,7 +12,7 @@ import javax.inject.Singleton
open class DeveloperModule {
@Provides
@Singleton
protected fun provideAnalyticsManager(context: Context?): AnalyticsManager {
open fun provideAnalyticsManager(context: Context): AnalyticsManager {
return EmptyAnalyticsManager()
}
}

View file

@ -5,10 +5,8 @@ import com.habitrpg.android.habitica.proxy.AnalyticsManagerImpl
import com.habitrpg.android.habitica.proxy.AnalyticsManager
import android.content.Context
//change debug proxy here by override methods
class ReleaseDeveloperModule : DeveloperModule() {
@Override
protected fun provideAnalyticsManager(context: Context?): AnalyticsManager {
return AnalyticsManagerImpl()
class ReleaseDeveloperModule: DeveloperModule() {
override fun provideAnalyticsManager(context: Context): AnalyticsManager {
return AnalyticsManagerImpl(context)
}
}

View file

@ -5,16 +5,18 @@ import com.google.firebase.crashlytics.internal.common.CrashlyticsCore
import com.habitrpg.android.habitica.proxy.AnalyticsManager
import android.content.Context
import com.google.firebase.analytics.FirebaseAnalytics
import com.amplitude.api.Amplitude
import android.os.Bundle
class AnalyticsManagerImpl: AnalyticsManager {
class AnalyticsManagerImpl(context: Context): AnalyticsManager {
private val firebaseAnalytics: com.google.firebase.analytics.FirebaseAnalytics
init(context: Context) {
firebaseAnalytics = FirebaseAnalytics.getInstance(this)
init {
firebaseAnalytics = FirebaseAnalytics.getInstance(context)
}
override fun logException(t: Throwabl?) {
override fun logException(t: Throwable) {
FirebaseCrashlytics.getInstance().recordException(t)
}
@ -27,7 +29,7 @@ class AnalyticsManagerImpl: AnalyticsManager {
FirebaseCrashlytics.getInstance().log(msg)
}
fun logEvent(eventName: String, data: Bundle) {
override fun logEvent(eventName: String, data: Bundle) {
firebaseAnalytics.logEvent(eventName, data)
}
}