From b3b59cbb4d7e70b0cc5bb3c0eefd5051a4d069bb Mon Sep 17 00:00:00 2001 From: Dan Lew Date: Tue, 15 Dec 2015 14:52:52 -0600 Subject: [PATCH] Ensure layers is reset when generating new images Otherwise we keep adding layers infinitely (even if we only use a handful of them). Worst-case scenario, this leads to memory leaks with Bitmaps retained at the end of the layer list. --- .../com/habitrpg/android/habitica/userpicture/UserPicture.java | 1 + 1 file changed, 1 insertion(+) diff --git a/Habitica/src/com/habitrpg/android/habitica/userpicture/UserPicture.java b/Habitica/src/com/habitrpg/android/habitica/userpicture/UserPicture.java index 0eca7d9ea..90e1fd43b 100644 --- a/Habitica/src/com/habitrpg/android/habitica/userpicture/UserPicture.java +++ b/Habitica/src/com/habitrpg/android/habitica/userpicture/UserPicture.java @@ -175,6 +175,7 @@ public class UserPicture { private void generateImage(List layerNames) { Integer layerNumber = 0; this.numOfTasks.set(layerNames.size()); + layers.clear(); for (String layer : layerNames) { layers.add(null); SpriteTarget target = new SpriteTarget(layerNumber, layer);