From c99ff5628881ccfb967379665fad5489c4c922a7 Mon Sep 17 00:00:00 2001 From: Phillip Thelen Date: Wed, 1 Feb 2017 14:15:24 +0100 Subject: [PATCH] add findbugs gradle plugin --- Habitica/build.gradle | 1 + .../ui/fragments/GemsPurchaseFragment.java | 15 +-------------- build.gradle | 1 + 3 files changed, 3 insertions(+), 14 deletions(-) diff --git a/Habitica/build.gradle b/Habitica/build.gradle index 6e56d1e59..2fca32fe2 100644 --- a/Habitica/build.gradle +++ b/Habitica/build.gradle @@ -2,6 +2,7 @@ apply plugin: 'com.android.application' apply plugin: 'com.android.databinding' apply plugin: 'io.fabric' apply plugin: 'com.neenbedankt.android-apt' +apply plugin: 'com.chaitanyapramod.findbugs-android' buildscript { repositories { diff --git a/Habitica/src/main/java/com/habitrpg/android/habitica/ui/fragments/GemsPurchaseFragment.java b/Habitica/src/main/java/com/habitrpg/android/habitica/ui/fragments/GemsPurchaseFragment.java index c71c0cf5c..3b1686785 100644 --- a/Habitica/src/main/java/com/habitrpg/android/habitica/ui/fragments/GemsPurchaseFragment.java +++ b/Habitica/src/main/java/com/habitrpg/android/habitica/ui/fragments/GemsPurchaseFragment.java @@ -2,34 +2,24 @@ package com.habitrpg.android.habitica.ui.fragments; import com.habitrpg.android.habitica.R; import com.habitrpg.android.habitica.components.AppComponent; -import com.habitrpg.android.habitica.events.BoughtGemsEvent; import com.habitrpg.android.habitica.helpers.PurchaseTypes; import com.habitrpg.android.habitica.proxy.ifce.CrashlyticsProxy; import com.habitrpg.android.habitica.ui.GemPurchaseOptionsView; import com.habitrpg.android.habitica.ui.activities.GemPurchaseActivity; -import org.greenrobot.eventbus.EventBus; import org.solovyev.android.checkout.ActivityCheckout; import org.solovyev.android.checkout.BillingRequests; -import org.solovyev.android.checkout.Checkout; import org.solovyev.android.checkout.Inventory; import org.solovyev.android.checkout.ProductTypes; -import org.solovyev.android.checkout.Purchase; -import org.solovyev.android.checkout.Purchases; import org.solovyev.android.checkout.RequestListener; import org.solovyev.android.checkout.Sku; -import android.content.Context; import android.os.Bundle; import android.support.annotation.NonNull; import android.support.annotation.Nullable; -import android.util.Log; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; -import android.widget.Button; - -import java.util.HashMap; import javax.inject.Inject; @@ -49,11 +39,8 @@ public class GemsPurchaseFragment extends BaseFragment implements GemPurchaseAct @Inject CrashlyticsProxy crashlyticsProxy; - private static final int GEMS_TO_ADD = 21; - Button btnPurchaseGems; private GemPurchaseActivity listener; private BillingRequests billingRequests; - private Inventory inventory; @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, @@ -85,7 +72,7 @@ public class GemsPurchaseFragment extends BaseFragment implements GemPurchaseAct public void setupCheckout() { final ActivityCheckout checkout = listener.getActivityCheckout(); if (checkout != null) { - inventory = checkout.makeInventory(); + Inventory inventory = checkout.makeInventory(); inventory.load(Inventory.Request.create() .loadAllPurchases().loadSkus(ProductTypes.IN_APP, PurchaseTypes.allGemTypes), diff --git a/build.gradle b/build.gradle index 744edbc25..fcf34d14b 100644 --- a/build.gradle +++ b/build.gradle @@ -9,6 +9,7 @@ buildscript { classpath 'com.android.databinding:dataBinder:1.0-rc4' classpath 'com.neenbedankt.gradle.plugins:android-apt:1.8' classpath 'com.google.gms:google-services:3.0.0' + classpath 'com.chaitanyapramod.gradle:findbugs-android:1.0' } }