From f07477de8eba6b69abf4fc01648619cf0c980d85 Mon Sep 17 00:00:00 2001
From: Parminder Singh <parmsingh129@gmail.com>
Date: Tue, 6 Jul 2021 17:48:36 +0530
Subject: [PATCH] Fixed accessibility focus on Daily checkbox and todo
 checkbox. Also fixed transaction ran on button click. (#1570)

---
 Habitica/res/layout/daily_item_card.xml                       | 4 +++-
 Habitica/res/layout/todo_item_card.xml                        | 4 +++-
 Habitica/res/values/strings.xml                               | 2 ++
 .../habitica/data/implementation/TaskRepositoryImpl.kt        | 2 +-
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/Habitica/res/layout/daily_item_card.xml b/Habitica/res/layout/daily_item_card.xml
index 03fd0b0f5..b8d778de6 100644
--- a/Habitica/res/layout/daily_item_card.xml
+++ b/Habitica/res/layout/daily_item_card.xml
@@ -26,7 +26,9 @@
                     android:id="@+id/checkBoxHolder"
                     android:layout_width="@dimen/button_width"
                     android:layout_height="match_parent"
-                    tools:background="@color/red_10">
+                    tools:background="@color/red_10"
+                    android:focusable="true"
+                    android:contentDescription="@string/daily_item_checkbox">
                     <View
                         android:id="@+id/checkBoxBackground"
                         android:layout_width="24dp"
diff --git a/Habitica/res/layout/todo_item_card.xml b/Habitica/res/layout/todo_item_card.xml
index 83b65bd55..0eabe1418 100644
--- a/Habitica/res/layout/todo_item_card.xml
+++ b/Habitica/res/layout/todo_item_card.xml
@@ -27,7 +27,9 @@
                     android:id="@+id/checkBoxHolder"
                     android:layout_width="@dimen/button_width"
                     android:layout_height="match_parent"
-                    tools:background="@color/red_10">
+                    tools:background="@color/red_10"
+                    android:focusable="true"
+                    android:contentDescription="@string/todo_item_checkbox">
                     <View
                         android:id="@+id/checkBoxBackground"
                         android:layout_width="24dp"
diff --git a/Habitica/res/values/strings.xml b/Habitica/res/values/strings.xml
index 5f578484d..fed84e82a 100644
--- a/Habitica/res/values/strings.xml
+++ b/Habitica/res/values/strings.xml
@@ -1166,4 +1166,6 @@
     <string name="locked_equipment_shop_dialog">You must purchase the previous items in this sequence to unlock</string>
     <string name="caused_damage">You caused damage to the boss</string>
     <string name="avatar_style">Style</string>
+    <string name="daily_item_checkbox">Daily Checkbox</string>
+    <string name="todo_item_checkbox">Todo Checkbox</string>
 </resources>
diff --git a/Habitica/src/main/java/com/habitrpg/android/habitica/data/implementation/TaskRepositoryImpl.kt b/Habitica/src/main/java/com/habitrpg/android/habitica/data/implementation/TaskRepositoryImpl.kt
index 64a3bb4e3..ae7457124 100644
--- a/Habitica/src/main/java/com/habitrpg/android/habitica/data/implementation/TaskRepositoryImpl.kt
+++ b/Habitica/src/main/java/com/habitrpg/android/habitica/data/implementation/TaskRepositoryImpl.kt
@@ -167,7 +167,7 @@ class TaskRepositoryImpl(localRepository: TaskLocalRepository, apiClient: ApiCli
                 }
             }
 
-            val stats = bgUser.stats
+            val stats = it.copyFromRealm(bgUser.stats)
             stats?.hp = res.hp
             stats?.exp = res.exp
             stats?.mp = res.mp