From f709a129b443cc593b8db8b52e9a9f6907060af4 Mon Sep 17 00:00:00 2001 From: Franze Jr Date: Sat, 12 Dec 2015 14:52:14 -0300 Subject: [PATCH 1/2] Fix OutOfBounds in Array on CheckListAdapter. Closes #221 --- .../android/habitica/ui/adapter/CheckListAdapter.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Habitica/src/com/habitrpg/android/habitica/ui/adapter/CheckListAdapter.java b/Habitica/src/com/habitrpg/android/habitica/ui/adapter/CheckListAdapter.java index f3d6c5d5e..c943e2ad4 100644 --- a/Habitica/src/com/habitrpg/android/habitica/ui/adapter/CheckListAdapter.java +++ b/Habitica/src/com/habitrpg/android/habitica/ui/adapter/CheckListAdapter.java @@ -63,8 +63,10 @@ public class CheckListAdapter extends RecyclerView.Adapter 0 && !mItems.isEmpty()){ + mItems.remove(position); + notifyItemRemoved(position); + } } From 3872a8586821c68bc5340eabeb3eb6fdfbb0a79f Mon Sep 17 00:00:00 2001 From: Franze Jr Date: Sun, 13 Dec 2015 10:42:15 -0300 Subject: [PATCH 2/2] #221 Change validation --- .../habitrpg/android/habitica/ui/adapter/CheckListAdapter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Habitica/src/com/habitrpg/android/habitica/ui/adapter/CheckListAdapter.java b/Habitica/src/com/habitrpg/android/habitica/ui/adapter/CheckListAdapter.java index c943e2ad4..2281841ec 100644 --- a/Habitica/src/com/habitrpg/android/habitica/ui/adapter/CheckListAdapter.java +++ b/Habitica/src/com/habitrpg/android/habitica/ui/adapter/CheckListAdapter.java @@ -63,7 +63,7 @@ public class CheckListAdapter extends RecyclerView.Adapter 0 && !mItems.isEmpty()){ + if(position >= 0 && position < mItems.size()){ mItems.remove(position); notifyItemRemoved(position); }