From 0d19c0de21b713cd4cfec22b7b8f4f44901fb43d Mon Sep 17 00:00:00 2001 From: Nick Gordon Date: Fri, 22 Nov 2013 14:40:44 -0800 Subject: [PATCH] Looked for opportunities to replace ngclass with boclass to improve performance, as well as replacing some instances of ng-if with bo-if --- views/options/social/chat-box.jade | 4 +-- views/options/social/group.jade | 2 +- views/shared/profiles/achievements.jade | 42 ++++++++++++------------- views/shared/tasks/lists.jade | 6 ++-- 4 files changed, 27 insertions(+), 27 deletions(-) diff --git a/views/options/social/chat-box.jade b/views/options/social/chat-box.jade index 871c165464..1ab956f3d6 100644 --- a/views/options/social/chat-box.jade +++ b/views/options/social/chat-box.jade @@ -5,8 +5,8 @@ form(ng-submit='postChat(group,message.content)') textarea.chat-textarea.option-content(style='height:6em;', ui-keypress='{13:"postChat(group,message.content)"}', ng-model='message.content', updateinterval='250', flag='@', at-user, auto-complete) span.user-list(ng-show='!isAtListHidden') ul.list-at-user - li(ng-repeat='user in users | filter:query.text | limitTo: 5', ng-click='autoComplete(user)') - span.username.label(class='label-contributor-{{user.contributor.level}}', ng-class='{"label-npc": user.backer.npc}') {{user.user}} + li(bindonce='users', ng-repeat='user in users | filter:query.text | limitTo: 5', ng-click='autoComplete(user)') + span.username.label(class='label-contributor-{{user.contributor.level}}', bo-class='{"label-npc": user.backer.npc}') {{user.user}} table.pull-right tr td diff --git a/views/options/social/group.jade b/views/options/social/group.jade index 1c8e0cd884..d007fa82d2 100644 --- a/views/options/social/group.jade +++ b/views/options/social/group.jade @@ -48,7 +48,7 @@ a.pull-right.gem-wallet(popover-trigger='mouseenter', popover-title='Guild Bank' a(ng-click='removeMember(group, member, true)') i.icon-ban-circle(tooltip='Boot Member') a - span(ng-class='{"badge badge-info": group.leader==member._id}', ng-click='clickMember(member._id, true)') + span(bindonce='group', bo-class='{"badge badge-info": group.leader==member._id}', ng-click='clickMember(member._id, true)') | {{member.profile.name}} tr(ng-if='group.memberCount > group.members.length') td. diff --git a/views/shared/profiles/achievements.jade b/views/shared/profiles/achievements.jade index 94ace40920..7c4e29729a 100644 --- a/views/shared/profiles/achievements.jade +++ b/views/shared/profiles/achievements.jade @@ -1,4 +1,4 @@ -.achievements-container +.achievements-container(bindonce) //
//
//
@@ -13,73 +13,73 @@ //
//
- div(ng-if='profile.backer.npc') + div(bo-if='profile.backer.npc') .achievement.achievement-helm h5 span.label.label-npc {{profile.backer.npc}} NPC small Backed the Kickstarter project at the maximum level! hr - div(ng-if='profile.contributor.level || user._id == profile._id') + div(bo-if='profile.contributor.level || user._id == profile._id') .achievement.achievement-firefox(ng-if='profile.contributor.level') div(ng-class='{muted: !profile.contributor.level}') h5 - span.label(ng-if='profile.contributor.level', class='label-contributor-{{profile.contributor.level}}') {{contribText(profile.contributor, profile.backer)}} - span.label(ng-if='!profile.contributor.level') Contributor + span.label(bo-if='profile.contributor.level', class='label-contributor-{{profile.contributor.level}}') {{contribText(profile.contributor, profile.backer)}} + span.label(bo-if='!profile.contributor.level') Contributor small. Has contributed to HabitRPG (code, design, pixel art, legal advice, docs, etc). Want this badge? Fix a bug :) hr - div(ng-if='profile.backer.tier') + div(bo-if='profile.backer.tier') .achievement.achievement-heart h5 Kickstarter Backer - ${{profile.backer.tier}} Tier small Backed the Kickstarter Project hr - div(ng-if='profile.achievements.streak || user._id == profile._id') - .achievement.achievement-thermometer(ng-show='profile.achievements.streak') - div(ng-class='{muted: !profile.achievements.streak}') + div(bo-if='profile.achievements.streak || user._id == profile._id') + .achievement.achievement-thermometer(bo-show='profile.achievements.streak') + div(bo-class='{muted: !profile.achievements.streak}') h5 {{profile.achievements.streak || 0 }} Streak Achievement(s) small Has performed {{profile.achievements.streak || 0 }} 21-day streaks on Dailies hr - div(ng-if='profile.achievements.ultimateGear || user._id == profile._id') - .achievement.achievement-armor(ng-show='profile.achievements.ultimateGear') - div(ng-class='{muted: !profile.achievements.ultimateGear}') + div(bo-if='profile.achievements.ultimateGear || user._id == profile._id') + .achievement.achievement-armor(bo-show='profile.achievements.ultimateGear') + div(bo-class='{muted: !profile.achievements.ultimateGear}') h5 Ultimate Gear small Has upgraded to the maximum weapon and armor set hr - div(ng-if='profile.achievements.beastMaster || user._id == profile._id') - .achievement.achievement-rat(ng-show='profile.achievements.beastMaster') - div(ng-class='{muted: !profile.achievements.beastMaster}') + div(bo-if='profile.achievements.beastMaster || user._id == profile._id') + .achievement.achievement-rat(bo-show='profile.achievements.beastMaster') + div(bo-class='{muted: !profile.achievements.beastMaster}') h5 Beast Master small Has found all 90 pets (insanely difficult, give this user props!) hr - div(ng-if='profile.achievements.helpedHabit') + div(bo-if='profile.achievements.helpedHabit') .achievement.achievement-tree h5 Helped Habit Grow small. Helped HabitRPG grow by filling out this survey. hr - div(ng-if='profile.achievements.originalUser || profile.achievements.veteran') + div(bo-if='profile.achievements.originalUser || profile.achievements.veteran') .achievement.achievement-cake - div(ng-if='profile.achievements.veteran') + div(bo-if='profile.achievements.veteran') h5 Veteran small | Has weathered Habit The Grey (our pre Angular website), and has gained many battle-scars from its bugs. - div(ng-if='profile.achievements.originalUser') + div(bo-if='profile.achievements.originalUser') h5 Original User! small | One of the very original early adopters, Talk about alpha tester! hr - div(ng-if='profile.achievements.challenges || user._id == profile._id') + div(bo-if='profile.achievements.challenges || user._id == profile._id') // This is a very strange icon to use. revisit .achievement.achievement-karaoke(ng-show='profile.achievements.challenges') - div(ng-class='{muted: !profile.achievements.challenges}') + div(bo-class='{muted: !profile.achievements.challenges}') h5 Was the winner in the following challenges ul li(ng-repeat='chal in profile.achievements.challenges') {{chal}} diff --git a/views/shared/tasks/lists.jade b/views/shared/tasks/lists.jade index b4e5da4c66..b149ea573c 100644 --- a/views/shared/tasks/lists.jade +++ b/views/shared/tasks/lists.jade @@ -3,7 +3,7 @@ // started to get unwieldy script(id='templates/habitrpg-tasks.html', type="text/ng-template") .grid - .module(ng-repeat='list in lists', ng-class='{"rewards-module": list.type==="reward"}') + .module(bindonce='lists', ng-repeat='list in lists', bo-class='{"rewards-module": list.type==="reward"}') .task-column(class='{{list.type}}s') // Todos export/graph options @@ -59,7 +59,7 @@ script(id='templates/habitrpg-tasks.html', type="text/ng-template") span.reward-cost {{item.value}} span.shop_gold // main content - span(ng-class='{"shop_{{item.classes}} shop-sprite item-img": true}') + span(bo-class='{"shop_{{item.classes}} shop-sprite item-img": true}') p.task-text {{item.text}} br @@ -73,7 +73,7 @@ script(id='templates/habitrpg-tasks.html', type="text/ng-template") ins.adsbygoogle(ng-init='initAds()', style='display: inline-block; width: 234px; height: 60px;', data-ad-client='ca-pub-3242350243827794', data-ad-slot='9529624576') // Todo Tabs - div(ng-if='main && list.type=="todo"', ng-class='{"tabbable tabs-below": list.type=="todo"}') + div(bo-if='main && list.type=="todo"', bo-class='{"tabbable tabs-below": list.type=="todo"}') button.task-action-btn.tile.spacious.bright(ng-show='list.showCompleted', ng-click='clearCompleted()') Clear Completed // remaining/completed tabs ul.nav.nav-tabs