From 1037510c9d8d9004272eb394fca08b61325fbae9 Mon Sep 17 00:00:00 2001 From: PitiTheGrey <35431804+PitiTheGrey@users.noreply.github.com> Date: Fri, 28 May 2021 23:59:14 +0200 Subject: [PATCH] Add 'questOwner' to the return data of a 'questActivity' webhook. (#13277) * Update webhook.js Add `questOwner: group.quest.leader,` to webhook.js * Update POST-groups_groupId_quests_invite.test.js Test if questOwner contains the correct data * Update POST-groups_groupId_quests_invite.test.js * Update webhooks.test.js --- test/api/unit/libs/webhooks.test.js | 2 ++ .../quests/POST-groups_groupId_quests_invite.test.js | 1 + website/server/libs/webhook.js | 1 + 3 files changed, 4 insertions(+) diff --git a/test/api/unit/libs/webhooks.test.js b/test/api/unit/libs/webhooks.test.js index 5a781ea129..539b074b5d 100644 --- a/test/api/unit/libs/webhooks.test.js +++ b/test/api/unit/libs/webhooks.test.js @@ -656,9 +656,11 @@ describe('webhooks', () => { id: 'group-id', name: 'some group', otherData: 'foo', + quest: {}, }, quest: { key: 'some-key', + questOwner: 'user-id', }, }; }); diff --git a/test/api/v3/integration/quests/POST-groups_groupId_quests_invite.test.js b/test/api/v3/integration/quests/POST-groups_groupId_quests_invite.test.js index dd6256661a..547cbd44ae 100644 --- a/test/api/v3/integration/quests/POST-groups_groupId_quests_invite.test.js +++ b/test/api/v3/integration/quests/POST-groups_groupId_quests_invite.test.js @@ -263,6 +263,7 @@ describe('POST /groups/:groupId/quests/invite/:questKey', () => { expect(body.group.id).to.eql(questingGroup.id); expect(body.group.name).to.eql(questingGroup.name); expect(body.quest.key).to.eql(PET_QUEST); + expect(body.quest.questOwner).to.eql(questingGroup.leader._id); }); }); }); diff --git a/website/server/libs/webhook.js b/website/server/libs/webhook.js index 896497af75..89e99a5aa4 100644 --- a/website/server/libs/webhook.js +++ b/website/server/libs/webhook.js @@ -183,6 +183,7 @@ export const questActivityWebhook = new WebhookSender({ }, quest: { key: quest.key, + questOwner: group.quest.leader, }, };