From 1752c08fd9312dacd0efda26751d318e7132e425 Mon Sep 17 00:00:00 2001 From: Sabe Jones Date: Mon, 2 Aug 2021 10:51:16 -0500 Subject: [PATCH] fix(teams): allow managers to reorder tasks --- website/server/controllers/api-v3/tasks/groups.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/website/server/controllers/api-v3/tasks/groups.js b/website/server/controllers/api-v3/tasks/groups.js index 3f66c93ee0..30bf179649 100644 --- a/website/server/controllers/api-v3/tasks/groups.js +++ b/website/server/controllers/api-v3/tasks/groups.js @@ -149,14 +149,15 @@ api.groupMoveTask = { if (task.type === 'todo' && task.completed) throw new BadRequest(res.t('cantMoveCompletedTodo')); + const groupFields = requiredGroupFields.concat(' managers'); const group = await Group.getGroup({ user, groupId: task.group.id, - fields: requiredGroupFields, + fields: groupFields, }); if (!group) throw new NotFound(res.t('groupNotFound')); - if (group.leader !== user._id) throw new NotAuthorized(res.t('onlyGroupLeaderCanEditTasks')); + if (canNotEditTasks(group, user)) throw new NotAuthorized(res.t('onlyGroupLeaderCanEditTasks')); const order = group.tasksOrder[`${task.type}s`];