From 1dc8be484260382e5e8bdc403970c59d2ad2fca2 Mon Sep 17 00:00:00 2001
From: Matteo Pagliazzi <matteopagliazzi@gmail.com>
Date: Thu, 7 Jan 2021 17:32:54 +0100
Subject: [PATCH] Stripe Upgrade Cleanup (#12882)

* chore(stripe): remove manual api version from code

* upgrade minor stripe version
---
 .../group-plans/group-payments-create.test.js        |  4 +---
 test/api/unit/libs/payments/stripe/checkout.test.js  |  4 +---
 .../unit/libs/payments/stripe/subscriptions.test.js  | 12 +++---------
 test/api/unit/libs/payments/stripe/webhooks.test.js  |  4 +---
 website/server/libs/payments/stripe/api.js           |  4 +---
 5 files changed, 7 insertions(+), 21 deletions(-)

diff --git a/test/api/unit/libs/payments/group-plans/group-payments-create.test.js b/test/api/unit/libs/payments/group-plans/group-payments-create.test.js
index 692c5a658b..383d7dfe6f 100644
--- a/test/api/unit/libs/payments/group-plans/group-payments-create.test.js
+++ b/test/api/unit/libs/payments/group-plans/group-payments-create.test.js
@@ -22,9 +22,7 @@ describe('Purchasing a group plan for group', () => {
 
   let plan; let group; let user; let
     data;
-  const stripe = stripeModule('test', {
-    apiVersion: '2020-08-27',
-  });
+  const stripe = stripeModule('test');
   const groupLeaderName = 'sender';
   const groupName = 'test group';
 
diff --git a/test/api/unit/libs/payments/stripe/checkout.test.js b/test/api/unit/libs/payments/stripe/checkout.test.js
index fe132f4c5e..ab72492401 100644
--- a/test/api/unit/libs/payments/stripe/checkout.test.js
+++ b/test/api/unit/libs/payments/stripe/checkout.test.js
@@ -17,9 +17,7 @@ import * as gems from '../../../../../../website/server/libs/payments/gems';
 const { i18n } = common;
 
 describe('Stripe - Checkout', () => {
-  const stripe = stripeModule('test', {
-    apiVersion: '2020-08-27',
-  });
+  const stripe = stripeModule('test');
   const BASE_URL = nconf.get('BASE_URL');
   const redirectUrls = {
     success_url: `${BASE_URL}/redirect/stripe-success-checkout`,
diff --git a/test/api/unit/libs/payments/stripe/subscriptions.test.js b/test/api/unit/libs/payments/stripe/subscriptions.test.js
index 96beeee523..c135f94b27 100644
--- a/test/api/unit/libs/payments/stripe/subscriptions.test.js
+++ b/test/api/unit/libs/payments/stripe/subscriptions.test.js
@@ -236,9 +236,7 @@ describe('Stripe - Subscriptions', () => {
   });
 
   describe('handlePaymentMethodChange', () => {
-    const stripe = stripeModule('test', {
-      apiVersion: '2020-08-27',
-    });
+    const stripe = stripeModule('test');
 
     it('updates the plan quantity based on the number of group members', async () => {
       const stripeIntentRetrieveStub = sandbox.stub(stripe.setupIntents, 'retrieve').resolves({
@@ -259,9 +257,7 @@ describe('Stripe - Subscriptions', () => {
   });
 
   describe('chargeForAdditionalGroupMember', () => {
-    const stripe = stripeModule('test', {
-      apiVersion: '2020-08-27',
-    });
+    const stripe = stripeModule('test');
     let stripeUpdateSubStub;
     const plan = common.content.subscriptionBlocks['group_monthly']; // eslint-disable-line dot-notation
 
@@ -302,9 +298,7 @@ describe('Stripe - Subscriptions', () => {
 
   describe('cancelSubscription', () => {
     const subKey = 'basic_3mo';
-    const stripe = stripeModule('test', {
-      apiVersion: '2020-08-27',
-    });
+    const stripe = stripeModule('test');
     let user; let groupId; let
       group;
 
diff --git a/test/api/unit/libs/payments/stripe/webhooks.test.js b/test/api/unit/libs/payments/stripe/webhooks.test.js
index b6d04151f3..816a0a9faa 100644
--- a/test/api/unit/libs/payments/stripe/webhooks.test.js
+++ b/test/api/unit/libs/payments/stripe/webhooks.test.js
@@ -16,9 +16,7 @@ import * as subscriptions from '../../../../../../website/server/libs/payments/s
 const { i18n } = common;
 
 describe('Stripe - Webhooks', () => {
-  const stripe = stripeModule('test', {
-    apiVersion: '2020-08-27',
-  });
+  const stripe = stripeModule('test');
   const endpointSecret = nconf.get('STRIPE_WEBHOOKS_ENDPOINT_SECRET');
   const headers = {};
   const body = {};
diff --git a/website/server/libs/payments/stripe/api.js b/website/server/libs/payments/stripe/api.js
index 635a1098bc..9b3ff5fc01 100644
--- a/website/server/libs/payments/stripe/api.js
+++ b/website/server/libs/payments/stripe/api.js
@@ -1,9 +1,7 @@
 import stripeModule from 'stripe';
 import nconf from 'nconf';
 
-let stripe = stripeModule(nconf.get('STRIPE_API_KEY'), {
-  apiVersion: '2020-08-27',
-});
+let stripe = stripeModule(nconf.get('STRIPE_API_KEY'));
 
 function setStripeApi (stripeInc) {
   stripe = stripeInc;