From 45b7c906c692789ea8cecf3dd8245e4526fe0d9c Mon Sep 17 00:00:00 2001 From: Tyler Renelle Date: Sun, 28 Oct 2012 15:26:43 -0400 Subject: [PATCH] cleanup of previous server crashing workaround, i think i figured it out --- lib/server/serverRoutes.js | 2 +- src/server/serverRoutes.coffee | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/server/serverRoutes.js b/lib/server/serverRoutes.js index 562010f82a..bc35f92d4c 100644 --- a/lib/server/serverRoutes.js +++ b/lib/server/serverRoutes.js @@ -40,7 +40,7 @@ module.exports = function(expressApp, root, derby) { return res.send(500, err); } userObj = user.get(); - if (!(userObj && userObj.stats && userObj.stats.money && !_.isEmpty(userObj.tasks))) { + if (!(userObj && !_.isEmpty(userObj.stats))) { console.log({ taskId: taskId, direction: direction, diff --git a/src/server/serverRoutes.coffee b/src/server/serverRoutes.coffee index a1fc0cd25b..33fa2dc5e7 100644 --- a/src/server/serverRoutes.coffee +++ b/src/server/serverRoutes.coffee @@ -32,8 +32,8 @@ module.exports = (expressApp, root, derby) -> model.fetch "users.#{uid}", (err, user) -> return res.send(500, err) if err userObj = user.get() - #FIXME The server keeps crashing. I think it's because some users are entering non-guids as their userId, test that here - unless userObj && userObj.stats && userObj.stats.money && !_.isEmpty(userObj.tasks) + # Server crashes without this, I think some users are entering non-guid userIds and/or trying to use the API without having an account + unless userObj && !_.isEmpty(userObj.stats) console.log {taskId:taskId, direction:direction, user:userObj, error: 'non-user attempted to score'} return res.send(500, "User #{uid} not found")