sudoxreboot/habitica-self-host
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica-self-host.git synced 2026-04-14 11:36:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Do not show the modal dialog for external links.

Browse source
This commit is contained in:
Adrian Winterstein 2024-09-28 16:23:13 +02:00
parent ce44b4a56c
commit 4ab2d25429
No known key found for this signature in database
GPG key ID: EDBA4B9F8D8E37AE
1 changed files with 2 additions and 54 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
website/client/src/mixins/externalLinks.js
View file

@ -1,59 +1,7 @@
/* eslint-disable no-continue */
/**
* Is the Link URL part of the TRUSTED_DOMAINS list
*
* @param {String} linkUrl
* @param {URL[]} trustedDomains
*/
export function isTrustedDomain (linkUrl, trustedDomains) {
const parsedURL = new URL(linkUrl);
return trustedDomains.some(domain => parsedURL.hostname.includes(domain.hostname));
}
const TRUSTED_DOMAINS = (import.meta.env.TRUSTED_DOMAINS ?? 'localhost').split(',')
.map(u => (u === 'localhost' ? new URL('http://localhost') : new URL(u)));
export default { export default {
methods: { methods: {
handleExternalLinks () { handleExternalLinks() {
if (TRUSTED_DOMAINS.length === 0) { // empty function, as the modal dialog for external links should not be shown at all
return;
}
// only links with an href attribute
// already handled links (.external-link/-ignore) are already filtered out
const allUnhandledLinks = document.querySelectorAll('a[href]:not(.external-link):not(.external-link-ignore)');
for (let i = 0; i < allUnhandledLinks.length; i += 1) {
const link = allUnhandledLinks[i];
// ignore links with existing link-exempt flag
if (link.offsetParent && link.offsetParent.classList.value.indexOf('link-exempt') !== -1) {
// attach the class to prevent another check on the next run
link.classList.add('external-link-ignore');
continue;
}
// no need to replace the link click handler when its a trusted domain
if (isTrustedDomain(link.href, TRUSTED_DOMAINS)) {
// attach the class to prevent another check on the next run
link.classList.add('external-link-ignore');
continue;
}
link.classList.add('external-link');
link.addEventListener('click', e => {
if (e.ctrlKey || e.metaKey) {
return;
}
e.stopPropagation();
e.preventDefault();
window.externalLink(link.href);
});
}
}, },
}, },
}; };