From 5a2cb5325bbbc4a6a762b02cf49d35b451bbb6f2 Mon Sep 17 00:00:00 2001 From: Adrian Winterstein Date: Sat, 28 Sep 2024 16:23:16 +0200 Subject: [PATCH] Allow to leave out some configurations even in production. --- website/server/libs/pushNotifications.js | 5 +++++ website/server/libs/slack.js | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/website/server/libs/pushNotifications.js b/website/server/libs/pushNotifications.js index a38162bf00..267685b840 100644 --- a/website/server/libs/pushNotifications.js +++ b/website/server/libs/pushNotifications.js @@ -28,6 +28,11 @@ function removePushDevice (user, pushDevice) { export const MAX_MESSAGE_LENGTH = 300; async function sendFCMNotification (user, pushDevice, payload) { + if (nconf.get('FIREBASE_PROJECT_ID') === undefined || nconf.get('FIREBASE_PROJECT_ID') === '') { + logger.info('Will not send push notification, because Firebase is not configured.'); + return; + } + const messaging = admin.messaging(); if (messaging === undefined) { return; diff --git a/website/server/libs/slack.js b/website/server/libs/slack.js index 13fabe0665..38327edce6 100644 --- a/website/server/libs/slack.js +++ b/website/server/libs/slack.js @@ -20,7 +20,7 @@ let flagSlack; let subscriptionSlack; try { - if (IS_TEST || IS_PRODUCTION) { + if ((IS_TEST || IS_PRODUCTION) && SLACK_FLAGGING_URL && SLACK_SUBSCRIPTIONS_URL) { flagSlack = new IncomingWebhook(SLACK_FLAGGING_URL); subscriptionSlack = new IncomingWebhook(SLACK_SUBSCRIPTIONS_URL); } else {