sudoxreboot/habitica-self-host
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica-self-host.git synced 2026-04-14 11:36:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Optimize database access for some use cases (#15444)

Browse source 
* optimize query when listing challenge tasks

* Optimize query for checking if user is party leader
This commit is contained in:
Phillip Thelen 2025-05-29 04:52:07 +02:00 committed by GitHub
parent 972f23e235
commit 5ba7d2395e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
website/server/controllers/api-v3/groups.js
View file

@ -1316,13 +1316,13 @@ api.getLookingForParty = {
const PAGE = req.query.page || 0;
const PAGE_START = USERS_PER_PAGE * PAGE;
const partyLed = await Group
.findOne({
type: 'party',
leader: user._id,
})
.select('_id')
.exec();
let partyLed = false;
if (user.party._id) {
const party = await Group.getGroup({ user, groupId: user.party._id });
if (party && party.leader === user._id) {
partyLed = true;
}
}
if (!partyLed) {
throw new BadRequest(apiError('notPartyLeader'));

2
website/server/libs/tasks/index.js
View file

@ -233,7 +233,7 @@ async function getTasks (req, res, options = {}) {
} else {
query.type = type.slice(0, -1); // removing the final "s"
}
} else {
} else if (!challenge) {
query.$and = [{
$or: [ // Exclude completed todos
{ type: 'todo', completed: false },