sudoxreboot/habitica-self-host
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica-self-host.git synced 2026-08-03 12:40:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

completed To-Dos: return the 30 most recent instead of 30 oldest (#7318)

Browse source
This commit is contained in:
Alys 2016-05-17 16:13:47 +10:00 committed by Matteo Pagliazzi
parent 9f12acf241
commit 810e4cbd78
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
test/api/v3/integration/tasks/GET-tasks_user.test.js
View file

@ -22,7 +22,7 @@ describe('GET /tasks/user', () => {
expect(tasks[0]._id).to.equal(createdTasks[0]._id);
});
it('returns completed todos sorted by completion date if req.query.type === "completeTodos"', async () => {
it('returns completed todos sorted by reverse completion date if req.query.type === "completeTodos"', async () => {
let todo1 = await user.post('/tasks/user', {text: 'todo to complete 1', type: 'todo'});
let todo2 = await user.post('/tasks/user', {text: 'todo to complete 2', type: 'todo'});
@ -37,6 +37,6 @@ describe('GET /tasks/user', () => {
let completedTodos = await user.get('/tasks/user?type=completedTodos');
expect(completedTodos.length).to.equal(2);
expect(completedTodos[completedTodos.length - 1].text).to.equal('todo to complete 1'); // last is the todo that was completed later
expect(completedTodos[completedTodos.length - 1].text).to.equal('todo to complete 2'); // last is the todo that was completed most recently
});
});

2
website/server/controllers/api-v3/tasks.js
View file

@ -127,7 +127,7 @@ async function _getTasks (req, res, user, challenge) {
type: 'todo',
completed: true,
}).limit(30).sort({ // TODO add ability to pick more than 30 completed todos
dateCompleted: 1,
dateCompleted: -1,
});
} else {
query.type = type.slice(0, -1); // removing the final "s"