sudoxreboot/habitica-self-host
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica-self-host.git synced 2026-04-14 19:47:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix tests being dependant on NEW_MYSTERY_ITEMS notification (#15288)

Browse source 
* Fix tests being dependant on NEW_MYSTERY_ITEMS notification

* remove only

* don’t actually need to check notification count

* fix tests

---------

Co-authored-by: Sabe Jones <sabrecat@gmail.com>
This commit is contained in:
Phillip Thelen 2024-09-04 01:21:00 +02:00 committed by GitHub
parent 2483e19bee
commit 8e643747f8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
test/api/v3/integration/tasks/groups/POST-tasks_group_id_assign_user_id.test.js
View file

@ -105,9 +105,9 @@ describe('POST /tasks/:taskId/assign/:memberId', () => {
const groupTask = await user.get(`/tasks/group/${guild._id}`); const groupTask = await user.get(`/tasks/group/${guild._id}`);
expect(member.notifications.length).to.equal(2); const lastNotification = member.notifications[member.notifications.length - 1];
expect(member.notifications[1].type).to.equal('GROUP_TASK_ASSIGNED'); expect(lastNotification.type).to.equal('GROUP_TASK_ASSIGNED');
expect(member.notifications[1].taskId).to.equal(groupTask._id); expect(lastNotification.taskId).to.equal(groupTask._id);
}); });
it('assigns a task to multiple users', async () => { it('assigns a task to multiple users', async () => {

4
test/api/v3/integration/tasks/groups/POST-tasks_task_id_unassign.test.js
View file

@ -89,10 +89,12 @@ describe('POST /tasks/:taskId/unassign/:memberId', () => {
}); });
it('removes task assignment notification from unassigned user', async () => { it('removes task assignment notification from unassigned user', async () => {
await member.sync();
const oldNotificationCount = member.notifications.length;
await user.post(`/tasks/${task._id}/unassign/${member._id}`); await user.post(`/tasks/${task._id}/unassign/${member._id}`);
await member.sync(); await member.sync();
expect(member.notifications.length).to.equal(1); // mystery items expect(member.notifications.length).to.equal(oldNotificationCount - 1);
}); });
it('unassigns a user and only that user from a task', async () => { it('unassigns a user and only that user from a task', async () => {