From 9e0e805d3523803e41de99e1fd0834d16ff08172 Mon Sep 17 00:00:00 2001
From: Natalie L <78037386+CuriousMagpie@users.noreply.github.com>
Date: Tue, 14 Dec 2021 16:54:57 -0500
Subject: [PATCH] Fix: Updated challenge.js to allow shortName to be editable
 by party leader (#13654)

* updated challenge.js to allow shortName to be editable

* fix api-v3 integration test error
---
 .../integration/challenges/PUT-challenges_challengeId.test.js   | 1 -
 website/server/models/challenge.js                              | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/test/api/v3/integration/challenges/PUT-challenges_challengeId.test.js b/test/api/v3/integration/challenges/PUT-challenges_challengeId.test.js
index 6b43a220a2..93e46a979d 100644
--- a/test/api/v3/integration/challenges/PUT-challenges_challengeId.test.js
+++ b/test/api/v3/integration/challenges/PUT-challenges_challengeId.test.js
@@ -74,7 +74,6 @@ describe('PUT /challenges/:challengeId', () => {
     expect(res.memberCount).to.equal(2);
     expect(res.tasksOrder).not.to.equal('new order');
     expect(res.official).to.equal(false);
-    expect(res.shortName).not.to.equal('new short name');
 
     expect(res.leader).to.eql({
       _id: user._id,
diff --git a/website/server/models/challenge.js b/website/server/models/challenge.js
index b1fe1edb45..b97f058f76 100644
--- a/website/server/models/challenge.js
+++ b/website/server/models/challenge.js
@@ -68,7 +68,7 @@ schema.pre('init', chal => {
 });
 
 // A list of additional fields that cannot be updated (but can be set on creation)
-const noUpdate = ['group', 'leader', 'official', 'shortName', 'prize'];
+const noUpdate = ['group', 'leader', 'official', 'prize'];
 schema.statics.sanitizeUpdate = function sanitizeUpdate (updateObj) {
   return this.sanitize(updateObj, noUpdate);
 };