From a8f397c674d4f0d86c530edd71bddb1d77702d08 Mon Sep 17 00:00:00 2001
From: Matteo Pagliazzi <matteopagliazzi@gmail.com>
Date: Wed, 15 Apr 2020 21:43:24 +0200
Subject: [PATCH] fix(join group): do not throw if inviter has does not exist

---
 website/server/controllers/api-v3/groups.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/website/server/controllers/api-v3/groups.js b/website/server/controllers/api-v3/groups.js
index e71e2b63f7..f411c9db1f 100644
--- a/website/server/controllers/api-v3/groups.js
+++ b/website/server/controllers/api-v3/groups.js
@@ -607,9 +607,11 @@ api.joinGroup = {
 
     let promises = [group.save(), user.save()];
 
-    if (inviter) {
-      inviter = await User.findById(inviter).exec();
+    // Load the inviter
+    if (inviter) inviter = await User.findById(inviter).exec();
 
+    // Check the inviter again, could be a deleted account
+    if (inviter) {
       const data = {
         headerText: common.i18n.t('invitationAcceptedHeader', inviter.preferences.language),
         bodyText: common.i18n.t('invitationAcceptedBody', {