mirror of
https://github.com/sudoxnym/habitica-self-host.git
synced 2026-08-01 03:30:25 +00:00
Getting rid of the completedList and completedIds, instead only
using the 'completed' attribute of the todo task. This fixes some issues were a task was at the same time in the todoIds and completedIds.
This commit is contained in:
parent
cf81339f7a
commit
b697e7bdf1
3 changed files with 21 additions and 21 deletions
|
|
@ -16,7 +16,7 @@ _ = require('underscore')
|
|||
|
||||
setupListReferences = (model) ->
|
||||
# Setup Task Lists
|
||||
taskTypes = ['habit', 'daily', 'todo', 'completed', 'reward']
|
||||
taskTypes = ['habit', 'daily', 'todo', 'reward']
|
||||
_.each taskTypes, (type) -> model.refList "_#{type}List", "_user.tasks", "_user.#{type}Ids"
|
||||
|
||||
# ========== ROUTES ==========
|
||||
|
|
@ -145,19 +145,6 @@ ready (model) ->
|
|||
task = user.at("tasks.#{i}")
|
||||
scoring.score(i, direction())
|
||||
|
||||
# Then move the todos to/from _todoList/_completedList
|
||||
if task.get('type') == 'todo'
|
||||
[from, to] = if (direction()=='up') then ['todo', 'completed'] else ['completed', 'todo']
|
||||
[from, to] = ["#{from}Ids", "#{to}Ids"]
|
||||
# Remove from source (just remove the id from id-list)
|
||||
fromIds = user.get(from)
|
||||
fromIds.splice(fromIds.indexOf(i), 1)
|
||||
user.set from, fromIds
|
||||
# Push to target (just the id to id-list)
|
||||
toIds = user.get(to)
|
||||
toIds.push i
|
||||
user.set to, toIds
|
||||
|
||||
exports.addTask = (e, el, next) ->
|
||||
type = $(el).attr('data-task-type')
|
||||
list = model.at "_#{type}List"
|
||||
|
|
@ -210,9 +197,15 @@ ready (model) ->
|
|||
task.remove()
|
||||
|
||||
exports.clearCompleted = (e, el) ->
|
||||
_.each model.get('_completedList'), (task) ->
|
||||
user.del('tasks.'+task.id)
|
||||
user.set('completedIds', [])
|
||||
todoIds = user.get('todoIds')
|
||||
removed = false
|
||||
_.each model.get('_todoList'), (task) ->
|
||||
if task.completed
|
||||
removed = true
|
||||
user.del('tasks.'+task.id)
|
||||
todoIds.splice(todoIds.indexOf(task.id), 1)
|
||||
if removed
|
||||
user.set('todoIds', todoIds)
|
||||
|
||||
exports.toggleDay = (e, el) ->
|
||||
task = model.at(e.target)
|
||||
|
|
@ -303,7 +296,7 @@ ready (model) ->
|
|||
|
||||
exports.reset = (e, el) ->
|
||||
userObj = user.get()
|
||||
taskTypes = ['habit', 'daily', 'todo', 'completed', 'reward']
|
||||
taskTypes = ['habit', 'daily', 'todo', 'reward']
|
||||
userObj.tasks = {}
|
||||
_.each taskTypes, (type) -> userObj["#{type}Ids"] = []
|
||||
userObj.balance = 2 if userObj.balance < 2 #only if they haven't manually bought tokens
|
||||
|
|
|
|||
|
|
@ -12,7 +12,6 @@ module.exports.userSchema = ->
|
|||
habitIds: []
|
||||
dailyIds: []
|
||||
todoIds: []
|
||||
completedIds: []
|
||||
rewardIds: []
|
||||
|
||||
for task in content.defaultTasks
|
||||
|
|
|
|||
|
|
@ -210,13 +210,21 @@
|
|||
<div class="tab-content">
|
||||
<div class="tab-pane active" id="tab1">
|
||||
<ul class='todos'>
|
||||
{#each _todoList as :task}<app:task />{/}
|
||||
{#each _todoList as :task}
|
||||
{#if not(:task.completed)}
|
||||
<app:task />
|
||||
{/}
|
||||
{/}
|
||||
</ul>
|
||||
<app:newTask type=todo><input value={_newTodo} type="text" name=new-task placeholder="New Todo"/></app:newTask>
|
||||
</div>
|
||||
<div class="tab-pane" id="tab2">
|
||||
<ul class='completeds'>
|
||||
{#each _completedList as :task}<app:task />{/}
|
||||
{#each _todoList as :task}
|
||||
{#if :task.completed}
|
||||
<app:task />
|
||||
{/}
|
||||
{/}
|
||||
</ul>
|
||||
<a x-bind=click:clearCompleted>Clear Completed</a>
|
||||
</div>
|
||||
|
|
|
|||
Loading…
Reference in a new issue