From e21f64edaf2af0e64b935dd729e992c46e063601 Mon Sep 17 00:00:00 2001
From: Matteo Pagliazzi <matteopagliazzi@gmail.com>
Date: Mon, 30 Mar 2020 19:04:55 +0200
Subject: [PATCH] fix(exports): disable non-working code and throw errors
 earlier when using the xml export (#12031)

---
 .../controllers/top-level/dataexport.js       | 54 +++++++++++--------
 1 file changed, 32 insertions(+), 22 deletions(-)

diff --git a/website/server/controllers/top-level/dataexport.js b/website/server/controllers/top-level/dataexport.js
index a9c5cecbfd..9de16046ed 100644
--- a/website/server/controllers/top-level/dataexport.js
+++ b/website/server/controllers/top-level/dataexport.js
@@ -1,9 +1,9 @@
 import _ from 'lodash';
 import moment from 'moment';
 import * as js2xml from 'js2xmlparser';
-import Pageres from 'pageres';
-import nconf from 'nconf';
-import got from 'got';
+// import Pageres from 'pageres';
+// import nconf from 'nconf';
+// import got from 'got';
 import md from 'habitica-markdown';
 import csvStringify from '../../libs/csvStringify';
 import {
@@ -11,15 +11,15 @@ import {
 } from '../../libs/errors';
 import * as Tasks from '../../models/task';
 import * as inboxLib from '../../libs/inbox';
-import { model as User } from '../../models/user';
+// import { model as User } from '../../models/user';
 import { authWithSession } from '../../middlewares/auth';
-import {
+/* import {
   S3,
-} from '../../libs/aws';
+} from '../../libs/aws'; */
 
-const S3_BUCKET = nconf.get('S3_BUCKET');
+// const S3_BUCKET = nconf.get('S3_BUCKET');
 
-const BASE_URL = nconf.get('BASE_URL');
+// const BASE_URL = nconf.get('BASE_URL');
 
 const api = {};
 
@@ -172,17 +172,18 @@ api.exportUserDataXml = {
   middlewares: [authWithSession],
   async handler (req, res) {
     const userData = await _getUserDataForExport(res.locals.user, true);
+    const xmlData = js2xml.parse('user', userData, {
+      cdataInvalidChars: true,
+      declaration: {
+        include: false,
+      },
+    });
 
     res.set({
       'Content-Type': 'text/xml',
       'Content-disposition': 'attachment; filename=habitica-user-data.xml',
     });
-    res.status(200).send(js2xml.parse('user', userData, {
-      cdataInvalidChars: true,
-      declaration: {
-        include: false,
-      },
-    }));
+    res.status(200).send(xmlData);
   },
 };
 
@@ -202,13 +203,18 @@ api.exportUserAvatarHtml = {
   method: 'GET',
   url: '/export/avatar-:memberId.html',
   // middlewares: [locals],
-  async handler (req, res) {
-    req.checkParams('memberId', res.t('memberIdRequired')).notEmpty().isUUID();
+  async handler (/* req, res */) {
+    throw new NotFound('This API route is currently not available. See https://github.com/HabitRPG/habitica/issues/9489.');
+
+    /* req.checkParams('memberId', res.t('memberIdRequired')).notEmpty().isUUID();
 
     const validationErrors = req.validationErrors();
     if (validationErrors) throw validationErrors;
 
     const { memberId } = req.params;
+
+    throw new NotFound('This API route is currently not available. See https://github.com/HabitRPG/habitica/issues/9489.');
+
     const member = await User
       .findById(memberId)
       .select('stats profile items achievements preferences backer contributor')
@@ -218,7 +224,7 @@ api.exportUserAvatarHtml = {
     res.render('avatar-static', {
       title: member.profile.name,
       env: _.defaults({ user: member }, res.locals.habitrpg),
-    });
+    }); */
   },
 };
 
@@ -235,8 +241,10 @@ api.exportUserAvatarHtml = {
 api.exportUserAvatarPng = {
   method: 'GET',
   url: '/export/avatar-:memberId.png',
-  async handler (req, res) {
-    req.checkParams('memberId', res.t('memberIdRequired')).notEmpty().isUUID();
+  async handler (/* req, res */) {
+    throw new NotFound('This API route is currently not available. See https://github.com/HabitRPG/habitica/issues/9489.');
+
+    /* req.checkParams('memberId', res.t('memberIdRequired')).notEmpty().isUUID();
 
     const validationErrors = req.validationErrors();
     if (validationErrors) throw validationErrors;
@@ -251,13 +259,15 @@ api.exportUserAvatarPng = {
       response = await got.head(s3url); // TODO add timeout and retries
     } catch (gotError) {
       // If the file does not exist AWS S3 can return a 403 error
-      if (gotError.code !== 'ENOTFOUND' && gotError.statusCode !== 404 && gotError.statusCode !== 403) {
+      if (gotError.code !== 'ENOTFOUND' && gotError.statusCode
+      !== 404 && gotError.statusCode !== 403) {
         throw gotError;
       }
     }
 
     // cache images for 30 minutes on aws, else upload a new one
-    if (response && response.statusCode === 200 && moment().diff(response.headers['last-modified'], 'minutes') < 30) {
+    if (response && response.statusCode === 200 && moment()
+    .diff(response.headers['last-modified'], 'minutes') < 30) {
       return res.redirect(s3url);
     }
 
@@ -288,7 +298,7 @@ api.exportUserAvatarPng = {
       });
     });
 
-    return res.redirect(s3res.Location);
+    return res.redirect(s3res.Location); */
   },
 };