From ead42e7cef968aa8ae82bf5ba1ee4e893abc2e4e Mon Sep 17 00:00:00 2001 From: Tyler Renelle Date: Wed, 1 Oct 2014 15:43:50 -0600 Subject: [PATCH] fix(memleak): temp, wonky fix to #4079 . Sets closure vars `user` to null in api.batchUpdate(). More will be needed --- src/controllers/user.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/controllers/user.js b/src/controllers/user.js index 1d5ae1177e..422d1ccf29 100644 --- a/src/controllers/user.js +++ b/src/controllers/user.js @@ -444,14 +444,17 @@ api.batchUpdate = function(req, res, next) { }); // call all the operations, then return the user object to the requester - async.waterfall(ops, function(err,user) { + async.waterfall(ops, function(err,_user) { res.json = oldJson; res.send = oldSend; if (err) return next(err); - var response = user.toJSON(); + var response = _user.toJSON(); response.wasModified = res.locals.wasModified; + user.fns.nullify(); + user = res.locals.user = oldSend = oldJson = oldSave = null; + // return only drops & streaks if (response._tmp && response._tmp.drop){ res.json(200, {_tmp: {drop: response._tmp.drop}, _v: response._v});