From eb99ca0411367614f4a5b4db1a1d52f9e2b328dd Mon Sep 17 00:00:00 2001
From: SabreCat <sabe@habitica.com>
Date: Tue, 17 May 2022 14:02:18 -0500
Subject: [PATCH] fix(cron): reset completions even if Daily wasn't due

---
 scripts/team-cron.js | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/scripts/team-cron.js b/scripts/team-cron.js
index 78fbd7d3fb..e1792e9869 100644
--- a/scripts/team-cron.js
+++ b/scripts/team-cron.js
@@ -52,20 +52,22 @@ async function updateTeamTasks (team) {
     });
     forEach(tasksByType.dailys, daily => {
       let processChecklist = false;
+      let assignments = 0;
+      let completions = 0;
+      for (const assignedUser in daily.group.assignedUsers) {
+        if (Object.prototype.hasOwnProperty.call(daily.group.assignedUsers, assignedUser)) {
+          assignments += 1;
+          if (daily.group.assignedUsers[assignedUser].completed) {
+            completions += 1;
+            daily.group.assignedUsers[assignedUser].completed = false;
+          }
+        }
+      }
+      if (completions > 0) daily.markModified('group.assignedUsers');
       if (daily.completed) {
         processChecklist = true;
         daily.completed = false;
       } else if (shouldDo(team.cron.lastProcessed, daily, teamLeader.preferences)) {
-        let assignments = 0;
-        let completions = 0;
-        for (const assignedUser in daily.group.assignedUsers) {
-          if (Object.prototype.hasOwnProperty.call(daily.group.assignedUsers, assignedUser)) {
-            assignments += 1;
-            if (daily.group.assignedUsers[assignedUser].completed) completions += 1;
-            daily.group.assignedUsers[assignedUser].completed = false;
-            daily.markModified('group.assignedUsers');
-          }
-        }
         processChecklist = true;
         const delta = TASK_VALUE_CHANGE_FACTOR ** daily.value;
         if (assignments > 0) {