From f631712a454c8b1a77af5487f788dba2210cc5c2 Mon Sep 17 00:00:00 2001 From: Alys Date: Thu, 18 Feb 2016 18:52:09 +1000 Subject: [PATCH] deemphasise the warning that spritesheets might be too large for mobile safari - ref https://github.com/HabitRPG/habitrpg/pull/6683#issuecomment-185462180 --- tasks/gulp-sprites.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tasks/gulp-sprites.js b/tasks/gulp-sprites.js index 18c289f47c..a5c86fc291 100644 --- a/tasks/gulp-sprites.js +++ b/tasks/gulp-sprites.js @@ -41,13 +41,12 @@ gulp.task('sprites:checkCompiledDimensions', ['sprites:main', 'sprites:largeSpri if (spriteSize > MAX_SPRITESHEET_SIZE) { numberOfSheetsThatAreTooBig++; let name = basename(img, '.png'); - console.error(`WARNING: ${name} is too big - ${spriteSize} > ${MAX_SPRITESHEET_SIZE}`); + console.error(`WARNING: ${name} might be too big - ${spriteSize} > ${MAX_SPRITESHEET_SIZE}`); } }); if (numberOfSheetsThatAreTooBig > 0) { - console.error(`${numberOfSheetsThatAreTooBig} sheets are too big :(`); - console.error('Mobile Safari may be unhappy with you'); + console.error(`${numberOfSheetsThatAreTooBig} sheets might too big for mobile Safari to be able to handle them, but there is a margin of error in these calculations so it is probably okay. Mention this to an admin so they can test a staging site on mobile Safari after your PR is merged.`); // https://github.com/HabitRPG/habitrpg/pull/6683#issuecomment-185462180 } else { console.log('All images are within the correct dimensions'); }