From f967962996be69a5335454610af76d10e1db08b8 Mon Sep 17 00:00:00 2001 From: Tyler Renelle Date: Thu, 30 Jan 2014 21:33:28 -0700 Subject: [PATCH] fix(batch-update): send errors to client if batch-update found an error, crash pid. --- src/controllers/user.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/controllers/user.js b/src/controllers/user.js index 063aa5cceb..89116bd3ac 100644 --- a/src/controllers/user.js +++ b/src/controllers/user.js @@ -472,9 +472,8 @@ api.batchUpdate = function(req, res, next) { var callOp = function(_req, cb) { res.send = res.json = function(code, data) { - if (_.isNumber(code) && code >= 400) - console.error({code: code, data: data}); - //FIXME send error messages down + if (_.isNumber(code) && code >= 500) + return cb(code+": "+ (data.message ? data.message : data.err ? data.err : JSON.stringify(data))); return cb(); }; api[_req.op](_req, res); @@ -495,7 +494,7 @@ api.batchUpdate = function(req, res, next) { async.series(ops, function(err) { res.json = oldJson; res.send = oldSend; - if (err) return res.json(500, {err: err}); + if (err) return next(err); var response = user.toJSON(); response.wasModified = res.locals.wasModified;