From c0bf2cffeaebb2a39edce5df3ca3e1a49b772edc Mon Sep 17 00:00:00 2001 From: Jalansh Date: Sun, 9 Aug 2020 21:55:59 +0530 Subject: [PATCH 01/16] Casting Chilling Frost and Stealth skill again will not be processed and return an error instead. Fixes #12361. (#12404) * Added logic for a repeating Chilling Frost skill. Added test case for redundant chilling frost skill cast. Added comments for the logic of repeating Stealth skill because of an error. * Added logic for a repeating Stealth skill. Avoiding MP reduction still pending because of console error. Test cases pending. * Completed the logic for a repeated Stealth skill. Added repeated frost skill cast check in common. Removed exclusive test. Test cases are pending. * Added test case for Stealth skill recast. Fixed lint errors. Fixed a flaw in if statement which led to test case failure. * Fixed lint errors in test case. * Added a common JSON entry for skil recasts in three files. Other files remaining. Added Chilling Frost recast check in common code. Modified test cases. * Added spellDisabled condition in client code. * Reverted JSON messages for three languages. Added spellAlreadyCast attribute to JSON file in locales/en. Made changes for showing appropriate message in client code. * Added an import for throwing BadRequest in common code. Modified test case accordingly. * Update website/common/script/content/spells.js Co-authored-by: Matteo Pagliazzi * Added target and req attributes in cast() method arguments. * Changed common code test case because of increased function parameters. Moved chilling frost test casse to common tests instead of server tests. * Changed the test case format in common tests. * Added a missing done statement. * Fixed a minor error which led to failing test case. Removed the exclusive test which led to lint error. * Fixed lint errors. * Added a class named 'disabled' for the frontend change. * fix(skills): style cleanup * fix(skills): unfix Co-authored-by: Matteo Pagliazzi Co-authored-by: Sabe Jones --- .../user/POST-user_class_cast_spellId.test.js | 17 +++++++++++++++ test/common/ops/spells.js | 21 ++++++++++++++++++- .../client/src/components/tasks/spells.vue | 21 +++++++++++-------- website/common/locales/en/spells.json | 5 ++--- website/common/script/content/spells.js | 11 ++++++---- website/server/libs/spells.js | 14 +++++++++++++ 6 files changed, 72 insertions(+), 17 deletions(-) diff --git a/test/api/v3/integration/user/POST-user_class_cast_spellId.test.js b/test/api/v3/integration/user/POST-user_class_cast_spellId.test.js index 56c6a0a940..78a9d0d4b8 100644 --- a/test/api/v3/integration/user/POST-user_class_cast_spellId.test.js +++ b/test/api/v3/integration/user/POST-user_class_cast_spellId.test.js @@ -161,6 +161,23 @@ describe('POST /user/class/cast/:spellId', () => { }); }); + it('Issue #12361: returns an error if stealth has already been cast', async () => { + await user.update({ + 'stats.class': 'rogue', + 'stats.lvl': 15, + 'stats.mp': 400, + 'stats.buffs.stealth': 1, + }); + await user.sync(); + await expect(user.post('/user/class/cast/stealth')) + .to.eventually.be.rejected.and.eql({ + code: 400, + error: 'BadRequest', + message: t('spellAlreadyCast'), + }); + expect(user.stats.mp).to.equal(400); + }); + it('returns an error if targeted party member doesn\'t exist', async () => { const { groupLeader } = await createAndPopulateGroup({ groupDetails: { type: 'party', privacy: 'private' }, diff --git a/test/common/ops/spells.js b/test/common/ops/spells.js index 939b7caab5..1f185c37f2 100644 --- a/test/common/ops/spells.js +++ b/test/common/ops/spells.js @@ -4,6 +4,7 @@ import { import spells from '../../../website/common/script/content/spells'; import { NotAuthorized, + BadRequest, } from '../../../website/common/script/libs/errors'; import i18n from '../../../website/common/script/i18n'; @@ -25,7 +26,7 @@ describe('shared.ops.spells', () => { const spell = spells.healer.heal; try { - spell.cast(user); + spell.cast(user, null, { language: 'en' }); } catch (err) { expect(err).to.be.an.instanceof(NotAuthorized); expect(err.message).to.equal(i18n.t('messageHealthAlreadyMax')); @@ -35,4 +36,22 @@ describe('shared.ops.spells', () => { done(); } }); + + it('Issue #12361: returns an error if chilling frost has already been cast', done => { + user.stats.class = 'wizard'; + user.stats.lvl = 15; + user.stats.mp = 400; + user.stats.buffs.streaks = true; + + const spell = spells.wizard.frost; + try { + spell.cast(user, null, { language: 'en' }); + } catch (err) { + expect(err).to.be.an.instanceof(BadRequest); + expect(err.message).to.equal(i18n.t('spellAlreadyCast')); + expect(user.stats.mp).to.eql(400); + + done(); + } + }); }); diff --git a/website/client/src/components/tasks/spells.vue b/website/client/src/components/tasks/spells.vue index 481539a9d6..216e85c613 100644 --- a/website/client/src/components/tasks/spells.vue +++ b/website/client/src/components/tasks/spells.vue @@ -42,12 +42,14 @@ :key="key" v-b-popover.hover.auto="skillNotes(skill)" class="col-12 col-md-3" - @click="castStart(skill)" + @click="!spellDisabled(key) ? castStart(skill) : null" > -
+
-
Number of dailies that will be avoided: <%= number %>.", - "spellRogueStealthMaxedOut": "You have already avoided all your dailies; there's no need to cast this again.", "spellHealerHealText": "Healing Light", "spellHealerHealNotes": "Shining light restores your health! (Based on: CON and INT)", @@ -76,5 +74,6 @@ "challengeTasksNoCast": "Casting a skill on challenge tasks is not allowed.", "groupTasksNoCast": "Casting a skill on group tasks is not allowed.", "spellNotOwned": "You don't own this skill.", - "spellLevelTooHigh": "You must be level <%= level %> to use this skill." + "spellLevelTooHigh": "You must be level <%= level %> to use this skill.", + "spellAlreadyCast": "You've cast this skill already. It won't have any additional effect." } diff --git a/website/common/script/content/spells.js b/website/common/script/content/spells.js index 29d6c019af..93940c3ba5 100644 --- a/website/common/script/content/spells.js +++ b/website/common/script/content/spells.js @@ -1,6 +1,6 @@ import each from 'lodash/each'; import t from './translation'; -import { NotAuthorized } from '../libs/errors'; +import { NotAuthorized, BadRequest } from '../libs/errors'; import statsComputed from '../libs/statsComputed'; // eslint-disable-line import/no-cycle import setDebuffPotionItems from '../libs/setDebuffPotionItems'; // eslint-disable-line import/no-cycle import crit from '../fns/crit'; // eslint-disable-line import/no-cycle @@ -104,7 +104,10 @@ spells.wizard = { lvl: 14, target: 'self', notes: t('spellWizardFrostNotes'), - cast (user) { + cast (user, target, req) { + // Check if chilling frost skill has been previously casted or not. + // See #12361 for more details. + if (user.stats.buffs.streaks === true) throw new BadRequest(t('spellAlreadyCast')(req.language)); user.stats.buffs.streaks = true; }, }, @@ -226,8 +229,8 @@ spells.healer = { lvl: 11, target: 'self', notes: t('spellHealerHealNotes'), - cast (user) { - if (user.stats.hp >= 50) throw new NotAuthorized(t('messageHealthAlreadyMax')(user.language)); + cast (user, target, req) { + if (user.stats.hp >= 50) throw new NotAuthorized(t('messageHealthAlreadyMax')(req.language)); user.stats.hp += (statsComputed(user).con + statsComputed(user).int + 5) * 0.075; if (user.stats.hp > 50) user.stats.hp = 50; }, diff --git a/website/server/libs/spells.js b/website/server/libs/spells.js index 231402a453..c185bbf471 100644 --- a/website/server/libs/spells.js +++ b/website/server/libs/spells.js @@ -163,6 +163,20 @@ async function castSpell (req, res, { isV3 = false }) { task: results[1], }); } else if (targetType === 'self') { + const spellName = spell.key; + // Check if stealth skill has been previously casted or not. + // See #12361 for more details. + if (spellName === 'stealth') { + const incompleteDailiesDue = await Tasks.Task.countDocuments({ + userId: user._id, + type: 'daily', + completed: false, + isDue: true, + }).exec(); + if (user.stats.buffs.stealth >= incompleteDailiesDue) { + throw new BadRequest(res.t('spellAlreadyCast')); + } + } await castSelfSpell(req, user, spell, quantity); let userToJson = user; From 0a47af4ac3d3bcaa1faf6c1d06640e5598d9a1a1 Mon Sep 17 00:00:00 2001 From: Rogesson Date: Sun, 9 Aug 2020 14:44:46 -0300 Subject: [PATCH 02/16] update group members after accepting the quest (without page reload) (#12358) * update group members after accepting the quest (without page reload) * show quest information after starting * removing quest.progress.up assignment Co-authored-by: rogesson --- website/client/src/components/groups/questSidebarSection.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/website/client/src/components/groups/questSidebarSection.vue b/website/client/src/components/groups/questSidebarSection.vue index 24da128790..6adb4055f1 100644 --- a/website/client/src/components/groups/questSidebarSection.vue +++ b/website/client/src/components/groups/questSidebarSection.vue @@ -162,7 +162,7 @@ progress on the group doc? Each user could have different progress.--> {{ user.party.quest.progress.up | floor(10) }} {{ $t('pendingDamageLabel') }} + >{{ (user.party.quest.progress.up || 0) | floor(10) }} {{ $t('pendingDamageLabel') }}
@@ -425,6 +425,7 @@ export default { async questAccept (partyId) { const quest = await this.$store.dispatch('quests:sendAction', { groupId: partyId, action: 'quests/accept' }); this.user.party.quest = quest; + this.group.quest = quest; }, async questReject (partyId) { const quest = await this.$store.dispatch('quests:sendAction', { groupId: partyId, action: 'quests/reject' }); From 13a5b276e94e3e571e9a5d1fc641d5d0c82ac138 Mon Sep 17 00:00:00 2001 From: Carlton McFarlane Date: Sun, 9 Aug 2020 19:58:40 +0200 Subject: [PATCH 03/16] fix(quest shop): add an index to v-for loop (#12446) --- website/client/src/components/shops/quests/questInfo.vue | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/website/client/src/components/shops/quests/questInfo.vue b/website/client/src/components/shops/quests/questInfo.vue index 11e3e1e75b..b3020dc255 100644 --- a/website/client/src/components/shops/quests/questInfo.vue +++ b/website/client/src/components/shops/quests/questInfo.vue @@ -28,8 +28,8 @@
{{ $t('difficulty') + ':' }}
From d2fc7c0c3d5e8d54af752a8bfaf17615f4a93ab1 Mon Sep 17 00:00:00 2001 From: negue Date: Sun, 9 Aug 2020 22:25:56 +0200 Subject: [PATCH 04/16] UI: redesign DatePicker (#12418) * extract datepicker & settings as component + redesign * fix updating values + fix button styling + popover position * remove eslint-config-standard / html --- package-lock.json | 16 +- website/client/config/storybook/config.js | 1 - website/client/package-lock.json | 4 +- website/client/package.json | 2 +- .../client/src/assets/scss/datepicker.scss | 26 --- website/client/src/assets/scss/index.scss | 1 - .../client/src/components/tasks/taskModal.vue | 44 +--- .../src/components/ui/datepicker.stories.js | 19 ++ .../client/src/components/ui/datepicker.vue | 198 ++++++++++++++++++ website/common/locales/en/tasks.json | 1 + 10 files changed, 239 insertions(+), 73 deletions(-) delete mode 100644 website/client/src/assets/scss/datepicker.scss create mode 100644 website/client/src/components/ui/datepicker.stories.js create mode 100644 website/client/src/components/ui/datepicker.vue diff --git a/package-lock.json b/package-lock.json index c75305ea29..fd360a4251 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1153,11 +1153,6 @@ "uuid": "^8.0.0" } }, - "@sindresorhus/is": { - "version": "0.14.0", - "resolved": "https://registry.npmjs.org/@sindresorhus/is/-/is-0.14.0.tgz", - "integrity": "sha512-9NET910DNaIPngYnLLPeg+Ogzqsi9uM4mSboU5y6p8S5DzMTVEsJZrawi+BoDNUVBa2DhJqQYUFvMDfgU062LQ==" - }, "@sinonjs/commons": { "version": "1.8.0", "resolved": "https://registry.npmjs.org/@sinonjs/commons/-/commons-1.8.0.tgz", @@ -6665,9 +6660,9 @@ }, "dependencies": { "@sindresorhus/is": { - "version": "3.0.0", - "resolved": "https://registry.npmjs.org/@sindresorhus/is/-/is-3.0.0.tgz", - "integrity": "sha512-kqA5I6Yun7PBHk8WN9BBP1c7FfN2SrD05GuVSEYPqDb4nerv7HqYfgBfMIKmT/EuejURkJKLZuLyGKGs6WEG9w==" + "version": "3.1.0", + "resolved": "https://registry.npmjs.org/@sindresorhus/is/-/is-3.1.0.tgz", + "integrity": "sha512-n4J+zu52VdY43kdi/XdI9DzuMr1Mur8zFL5ZRG2opCans9aiFwkPxHYFEb5Xgy7n1Z4K6WfI4FpqUqsh3E8BPQ==" }, "@szmarczak/http-timer": { "version": "4.0.5", @@ -10573,6 +10568,11 @@ "semver": "^6.2.0" }, "dependencies": { + "@sindresorhus/is": { + "version": "0.14.0", + "resolved": "https://registry.npmjs.org/@sindresorhus/is/-/is-0.14.0.tgz", + "integrity": "sha512-9NET910DNaIPngYnLLPeg+Ogzqsi9uM4mSboU5y6p8S5DzMTVEsJZrawi+BoDNUVBa2DhJqQYUFvMDfgU062LQ==" + }, "got": { "version": "9.6.0", "resolved": "https://registry.npmjs.org/got/-/got-9.6.0.tgz", diff --git a/website/client/config/storybook/config.js b/website/client/config/storybook/config.js index fb3957a25e..63aa9f0c1d 100644 --- a/website/client/config/storybook/config.js +++ b/website/client/config/storybook/config.js @@ -2,7 +2,6 @@ import { configure } from '@storybook/vue'; import './margin.css'; import '../../src/assets/scss/index.scss'; -import '../../src/assets/scss/spacing.scss'; import '../../src/assets/css/sprites.css'; import '../../src/assets/css/sprites/spritesmith-main-0.css'; diff --git a/website/client/package-lock.json b/website/client/package-lock.json index d93e03ac43..57343a7022 100644 --- a/website/client/package-lock.json +++ b/website/client/package-lock.json @@ -19885,8 +19885,8 @@ } }, "vuejs-datepicker": { - "version": "git://github.com/habitrpg/vuejs-datepicker.git#5d237615463a84a23dd6f3f77c6ab577d68593ec", - "from": "git://github.com/habitrpg/vuejs-datepicker.git#5d237615463a84a23dd6f3f77c6ab577d68593ec" + "version": "git://github.com/habitrpg/vuejs-datepicker.git#153d339e4dbebb73733658aeda1d5b7fcc55b0a0", + "from": "git://github.com/habitrpg/vuejs-datepicker.git#153d339e4dbebb73733658aeda1d5b7fcc55b0a0" }, "w3c-hr-time": { "version": "1.0.2", diff --git a/website/client/package.json b/website/client/package.json index 04e4c330fe..8df0f2d610 100644 --- a/website/client/package.json +++ b/website/client/package.json @@ -59,7 +59,7 @@ "vue-router": "^3.3.4", "vue-template-compiler": "^2.6.11", "vuedraggable": "^2.24.0", - "vuejs-datepicker": "git://github.com/habitrpg/vuejs-datepicker.git#5d237615463a84a23dd6f3f77c6ab577d68593ec", + "vuejs-datepicker": "git://github.com/habitrpg/vuejs-datepicker.git#153d339e4dbebb73733658aeda1d5b7fcc55b0a0", "webpack": "^4.44.1" } } diff --git a/website/client/src/assets/scss/datepicker.scss b/website/client/src/assets/scss/datepicker.scss deleted file mode 100644 index 7ec0a7711b..0000000000 --- a/website/client/src/assets/scss/datepicker.scss +++ /dev/null @@ -1,26 +0,0 @@ -.vdp-datepicker .vdp-datepicker__calendar { - - .cell:not(.blank):not(.disabled).day:hover { - border-radius: 2px; - border: 1px solid $purple-400; - } - - .cell.selected, - .cell.selected.highlighted, - .cell.selected:hover { - color: $white; - background: $purple-300; - } - - .cell.highlighted { - background: rgba($purple-400, 0.24); - color: $purple-200; - } - - .cell.highlighted, - .cell.selected { - border-radius: 2px; - font-weight: bold; - } - -} \ No newline at end of file diff --git a/website/client/src/assets/scss/index.scss b/website/client/src/assets/scss/index.scss index 63dfcbc85f..424cffb0e7 100644 --- a/website/client/src/assets/scss/index.scss +++ b/website/client/src/assets/scss/index.scss @@ -36,5 +36,4 @@ @import './iconalert'; @import './tiers'; @import './payments'; -@import './datepicker.scss'; @import './spacing'; diff --git a/website/client/src/components/tasks/taskModal.vue b/website/client/src/components/tasks/taskModal.vue index 6669042b85..a02e8ce078 100644 --- a/website/client/src/components/tasks/taskModal.vue +++ b/website/client/src/components/tasks/taskModal.vue @@ -264,13 +264,8 @@ :text="$t('dueDate')" />
@@ -285,12 +280,8 @@ :text="$t('startDate')" />
@@ -787,27 +778,12 @@ } } - .vdp-datepicker.disabled, .input-group-outer.disabled { - .input-group:hover { - border-color: $gray-400; - } + .datetime-buttons { + display: flex; + flex-direction: row; - .input-group .form-control { - background-color: $gray-700; - border-color: $gray-500; - color: $gray-200; - } - - svg path { - opacity: 0.75; - fill: $gray-200; - } - } - - .vdp-datepicker { - .input-group-append { - width: auto; - min-width: 2rem; + .btn { + flex: 1; } } @@ -1067,8 +1043,8 @@ + + diff --git a/website/common/locales/en/tasks.json b/website/common/locales/en/tasks.json index b2bd6b26cd..f6c87b9873 100644 --- a/website/common/locales/en/tasks.json +++ b/website/common/locales/en/tasks.json @@ -81,6 +81,7 @@ "complete2": "Complete", "dated": "Dated", "today": "Today", + "tomorrow": "Tomorrow", "dueIn": "Due <%= dueIn %>", "due": "Due", "notDue": "Not Due", From 8796dbd8b8c834ffb24647fab3aebfd99a5db108 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 10 Aug 2020 15:25:31 +0200 Subject: [PATCH 05/16] build(deps): bump mongoose from 5.9.27 to 5.9.28 (#12449) Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.9.27 to 5.9.28. - [Release notes](https://github.com/Automattic/mongoose/releases) - [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md) - [Commits](https://github.com/Automattic/mongoose/compare/5.9.27...5.9.28) Signed-off-by: dependabot-preview[bot] Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> --- package-lock.json | 6 +++--- package.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index fd360a4251..06f36d7732 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9391,9 +9391,9 @@ } }, "mongoose": { - "version": "5.9.27", - "resolved": "https://registry.npmjs.org/mongoose/-/mongoose-5.9.27.tgz", - "integrity": "sha512-N8zj4pj9J2xJ2BnQ4NiIHEtmjPldtbmbEZOMz4phLTQr3KFWPR0T0I6EzQxNioHwmDbHD4VFzbEd755oD2SJxA==", + "version": "5.9.28", + "resolved": "https://registry.npmjs.org/mongoose/-/mongoose-5.9.28.tgz", + "integrity": "sha512-A8lNRk4eCQDzk+DagSMYdH94LAYrbTK83LgrUlzqdig3YXvizW3DApJqOWQ5DdhuimvsfiD0Z5NTVzXl/rgi2w==", "requires": { "bson": "^1.1.4", "kareem": "2.3.1", diff --git a/package.json b/package.json index 963132caa5..a692ce5541 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,7 @@ "method-override": "^3.0.0", "moment": "^2.27.0", "moment-recur": "^1.0.7", - "mongoose": "^5.9.27", + "mongoose": "^5.9.28", "morgan": "^1.10.0", "nconf": "^0.10.0", "node-gcm": "^1.0.3", From 2ff3c7326c439397d3586f76db935bfb439ec871 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 10 Aug 2020 15:28:07 +0200 Subject: [PATCH 06/16] build(deps): bump csv-stringify from 5.5.0 to 5.5.1 (#12451) Bumps [csv-stringify](https://github.com/adaltas/node-csv-stringify) from 5.5.0 to 5.5.1. - [Release notes](https://github.com/adaltas/node-csv-stringify/releases) - [Changelog](https://github.com/adaltas/node-csv-stringify/blob/master/CHANGELOG.md) - [Commits](https://github.com/adaltas/node-csv-stringify/compare/v5.5.0...v5.5.1) Signed-off-by: dependabot-preview[bot] Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> --- package-lock.json | 6 +++--- package.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index 06f36d7732..998e58d0f8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -3951,9 +3951,9 @@ } }, "csv-stringify": { - "version": "5.5.0", - "resolved": "https://registry.npmjs.org/csv-stringify/-/csv-stringify-5.5.0.tgz", - "integrity": "sha512-G05575DSO/9vFzQxZN+Srh30cNyHk0SM0ePyiTChMD5WVt7GMTVPBQf4rtgMF6mqhNCJUPw4pN8LDe8MF9EYOA==" + "version": "5.5.1", + "resolved": "https://registry.npmjs.org/csv-stringify/-/csv-stringify-5.5.1.tgz", + "integrity": "sha512-HM0/86Ks8OwFbaYLd495tqTs1NhscZL52dC4ieKYumy8+nawQYC0xZ63w1NqLf0M148T2YLYqowoImc1giPn0g==" }, "currently-unhandled": { "version": "0.4.1", diff --git a/package.json b/package.json index a692ce5541..fffdbe4e0a 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ "compression": "^1.7.4", "cookie-session": "^1.4.0", "coupon-code": "^0.4.5", - "csv-stringify": "^5.5.0", + "csv-stringify": "^5.5.1", "cwait": "^1.1.1", "domain-middleware": "~0.1.0", "eslint": "^6.8.0", From 24afffc2ae782fa47bdb2f466564dff6be083a66 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 10 Aug 2020 15:28:31 +0200 Subject: [PATCH 07/16] build(deps): bump @babel/core from 7.11.0 to 7.11.1 (#12452) Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.11.0 to 7.11.1. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.11.1/packages/babel-core) Signed-off-by: dependabot-preview[bot] Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> --- package-lock.json | 14 +++++++------- package.json | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index 998e58d0f8..bbcdcd734e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -23,15 +23,15 @@ } }, "@babel/core": { - "version": "7.11.0", - "resolved": "https://registry.npmjs.org/@babel/core/-/core-7.11.0.tgz", - "integrity": "sha512-mkLq8nwaXmDtFmRkQ8ED/eA2CnVw4zr7dCztKalZXBvdK5EeNUAesrrwUqjQEzFgomJssayzB0aqlOsP1vGLqg==", + "version": "7.11.1", + "resolved": "https://registry.npmjs.org/@babel/core/-/core-7.11.1.tgz", + "integrity": "sha512-XqF7F6FWQdKGGWAzGELL+aCO1p+lRY5Tj5/tbT3St1G8NaH70jhhDIKknIZaDans0OQBG5wRAldROLHSt44BgQ==", "requires": { "@babel/code-frame": "^7.10.4", "@babel/generator": "^7.11.0", "@babel/helper-module-transforms": "^7.11.0", "@babel/helpers": "^7.10.4", - "@babel/parser": "^7.11.0", + "@babel/parser": "^7.11.1", "@babel/template": "^7.10.4", "@babel/traverse": "^7.11.0", "@babel/types": "^7.11.0", @@ -78,9 +78,9 @@ } }, "@babel/parser": { - "version": "7.11.0", - "resolved": "https://registry.npmjs.org/@babel/parser/-/parser-7.11.0.tgz", - "integrity": "sha512-qvRvi4oI8xii8NllyEc4MDJjuZiNaRzyb7Y7lup1NqJV8TZHF4O27CcP+72WPn/k1zkgJ6WJfnIbk4jTsVAZHw==" + "version": "7.11.3", + "resolved": "https://registry.npmjs.org/@babel/parser/-/parser-7.11.3.tgz", + "integrity": "sha512-REo8xv7+sDxkKvoxEywIdsNFiZLybwdI7hcT5uEPyQrSMB4YQ973BfC9OOrD/81MaIjh6UxdulIQXkjmiH3PcA==" }, "@babel/traverse": { "version": "7.11.0", diff --git a/package.json b/package.json index fffdbe4e0a..9152bae27f 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "version": "4.151.3", "main": "./website/server/index.js", "dependencies": { - "@babel/core": "^7.11.0", + "@babel/core": "^7.11.1", "@babel/preset-env": "^7.11.0", "@babel/register": "^7.10.3", "@google-cloud/trace-agent": "^5.1.0", From 5ed007190a588001e0e0414e8f8667cd481a21e7 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 10 Aug 2020 15:28:41 +0200 Subject: [PATCH 08/16] build(deps): bump got from 11.5.1 to 11.5.2 (#12454) Bumps [got](https://github.com/sindresorhus/got) from 11.5.1 to 11.5.2. - [Release notes](https://github.com/sindresorhus/got/releases) - [Commits](https://github.com/sindresorhus/got/compare/v11.5.1...v11.5.2) Signed-off-by: dependabot-preview[bot] Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> --- package-lock.json | 22 +++++++++++----------- package.json | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/package-lock.json b/package-lock.json index bbcdcd734e..14c08819e4 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1153,6 +1153,11 @@ "uuid": "^8.0.0" } }, + "@sindresorhus/is": { + "version": "3.1.0", + "resolved": "https://registry.npmjs.org/@sindresorhus/is/-/is-3.1.0.tgz", + "integrity": "sha512-n4J+zu52VdY43kdi/XdI9DzuMr1Mur8zFL5ZRG2opCans9aiFwkPxHYFEb5Xgy7n1Z4K6WfI4FpqUqsh3E8BPQ==" + }, "@sinonjs/commons": { "version": "1.8.0", "resolved": "https://registry.npmjs.org/@sinonjs/commons/-/commons-1.8.0.tgz", @@ -6642,9 +6647,9 @@ } }, "got": { - "version": "11.5.1", - "resolved": "https://registry.npmjs.org/got/-/got-11.5.1.tgz", - "integrity": "sha512-reQEZcEBMTGnujmQ+Wm97mJs/OK6INtO6HmLI+xt3+9CvnRwWjXutUvb2mqr+Ao4Lu05Rx6+udx9sOQAmExMxA==", + "version": "11.5.2", + "resolved": "https://registry.npmjs.org/got/-/got-11.5.2.tgz", + "integrity": "sha512-yUhpEDLeuGiGJjRSzEq3kvt4zJtAcjKmhIiwNp/eUs75tRlXfWcHo5tcBaMQtnjHWC7nQYT5HkY/l0QOQTkVww==", "requires": { "@sindresorhus/is": "^3.0.0", "@szmarczak/http-timer": "^4.0.5", @@ -6659,11 +6664,6 @@ "responselike": "^2.0.0" }, "dependencies": { - "@sindresorhus/is": { - "version": "3.1.0", - "resolved": "https://registry.npmjs.org/@sindresorhus/is/-/is-3.1.0.tgz", - "integrity": "sha512-n4J+zu52VdY43kdi/XdI9DzuMr1Mur8zFL5ZRG2opCans9aiFwkPxHYFEb5Xgy7n1Z4K6WfI4FpqUqsh3E8BPQ==" - }, "@szmarczak/http-timer": { "version": "4.0.5", "resolved": "https://registry.npmjs.org/@szmarczak/http-timer/-/http-timer-4.0.5.tgz", @@ -6700,9 +6700,9 @@ "integrity": "sha512-bYL2d05vOSf1JEZNx5vSAtPuBMkX8K9EUutg7zlKvTqKXHt7RhWJFbmd7qakVuf13i+IkGmp6FwSsONOf6VYIg==" }, "get-stream": { - "version": "5.1.0", - "resolved": "https://registry.npmjs.org/get-stream/-/get-stream-5.1.0.tgz", - "integrity": "sha512-EXr1FOzrzTfGeL0gQdeFEvOMm2mzMOglyiOXSTpPC+iAjAKftbr3jpCMWynogwYnM+eSj9sHGc6wjIcDvYiygw==", + "version": "5.2.0", + "resolved": "https://registry.npmjs.org/get-stream/-/get-stream-5.2.0.tgz", + "integrity": "sha512-nBF+F1rAZVCu/p7rjzgA+Yb4lfYXrpl7a6VmJrU8wF9I1CKvP/QwPNZHnOlwbTkY6dvtFIzFMSyQXbLoTQPRpA==", "requires": { "pump": "^3.0.0" } diff --git a/package.json b/package.json index 9152bae27f..767eec572b 100644 --- a/package.json +++ b/package.json @@ -30,7 +30,7 @@ "express-basic-auth": "^1.1.5", "express-validator": "^5.2.0", "glob": "^7.1.6", - "got": "^11.5.0", + "got": "^11.5.2", "gulp": "^4.0.0", "gulp-babel": "^8.0.0", "gulp-imagemin": "^7.1.0", From 8a548a6a4de097e201bf936578503001fbd89431 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 10 Aug 2020 15:29:36 +0200 Subject: [PATCH 09/16] build(deps): bump bootstrap from 4.5.0 to 4.5.2 in /website/client (#12456) Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.5.0 to 4.5.2. - [Release notes](https://github.com/twbs/bootstrap/releases) - [Commits](https://github.com/twbs/bootstrap/compare/v4.5.0...v4.5.2) Signed-off-by: dependabot-preview[bot] Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> --- website/client/package-lock.json | 6 +++--- website/client/package.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/website/client/package-lock.json b/website/client/package-lock.json index 57343a7022..725854ad42 100644 --- a/website/client/package-lock.json +++ b/website/client/package-lock.json @@ -7148,9 +7148,9 @@ "integrity": "sha1-aN/1++YMUes3cl6p4+0xDcwed24=" }, "bootstrap": { - "version": "4.5.0", - "resolved": "https://registry.npmjs.org/bootstrap/-/bootstrap-4.5.0.tgz", - "integrity": "sha512-Z93QoXvodoVslA+PWNdk23Hze4RBYIkpb5h8I2HY2Tu2h7A0LpAgLcyrhrSUyo2/Oxm2l1fRZPs1e5hnxnliXA==" + "version": "4.5.2", + "resolved": "https://registry.npmjs.org/bootstrap/-/bootstrap-4.5.2.tgz", + "integrity": "sha512-vlGn0bcySYl/iV+BGA544JkkZP5LB3jsmkeKLFQakCOwCM3AOk7VkldBz4jrzSe+Z0Ezn99NVXa1o45cQY4R6A==" }, "bootstrap-vue": { "version": "2.16.0", diff --git a/website/client/package.json b/website/client/package.json index 8df0f2d610..dc1583673c 100644 --- a/website/client/package.json +++ b/website/client/package.json @@ -28,7 +28,7 @@ "axios": "^0.19.2", "axios-progress-bar": "^1.2.0", "babel-eslint": "^10.1.0", - "bootstrap": "^4.5.0", + "bootstrap": "^4.5.2", "bootstrap-vue": "^2.16.0", "chai": "^4.1.2", "core-js": "^3.6.5", From 7393ef5162396299682cf2b73cef075769ae04f3 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 10 Aug 2020 15:29:58 +0200 Subject: [PATCH 10/16] build(deps): bump vue-router from 3.3.4 to 3.4.2 in /website/client (#12457) Bumps [vue-router](https://github.com/vuejs/vue-router) from 3.3.4 to 3.4.2. - [Release notes](https://github.com/vuejs/vue-router/releases) - [Changelog](https://github.com/vuejs/vue-router/blob/dev/CHANGELOG.md) - [Commits](https://github.com/vuejs/vue-router/compare/v3.3.4...v3.4.2) Signed-off-by: dependabot-preview[bot] Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> --- website/client/package-lock.json | 6 +++--- website/client/package.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/website/client/package-lock.json b/website/client/package-lock.json index 725854ad42..d482cf2fc2 100644 --- a/website/client/package-lock.json +++ b/website/client/package-lock.json @@ -19842,9 +19842,9 @@ } }, "vue-router": { - "version": "3.3.4", - "resolved": "https://registry.npmjs.org/vue-router/-/vue-router-3.3.4.tgz", - "integrity": "sha512-SdKRBeoXUjaZ9R/8AyxsdTqkOfMcI5tWxPZOUX5Ie1BTL5rPSZ0O++pbiZCeYeythiZIdLEfkDiQPKIaWk5hDg==" + "version": "3.4.2", + "resolved": "https://registry.npmjs.org/vue-router/-/vue-router-3.4.2.tgz", + "integrity": "sha512-n3Ok70hW0EpcJF4lcWIwSHAQbFTnIOLl/fhO8+oTs4jHNtBNsovcVvPZeTOyKEd8C3xF1Crft2ASuOiVT5K1mw==" }, "vue-style-loader": { "version": "4.1.2", diff --git a/website/client/package.json b/website/client/package.json index dc1583673c..fe64c758af 100644 --- a/website/client/package.json +++ b/website/client/package.json @@ -56,7 +56,7 @@ "vue": "^2.6.11", "vue-cli-plugin-storybook": "^0.6.1", "vue-mugen-scroll": "^0.2.6", - "vue-router": "^3.3.4", + "vue-router": "^3.4.2", "vue-template-compiler": "^2.6.11", "vuedraggable": "^2.24.0", "vuejs-datepicker": "git://github.com/habitrpg/vuejs-datepicker.git#153d339e4dbebb73733658aeda1d5b7fcc55b0a0", From 5b2b51e4f6c4c701b069ea378e6d5ebb8cb10e6f Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 10 Aug 2020 15:31:26 +0200 Subject: [PATCH 11/16] build(deps): bump superagent from 5.3.1 to 6.0.0 (#12450) Bumps [superagent](https://github.com/visionmedia/superagent) from 5.3.1 to 6.0.0. - [Release notes](https://github.com/visionmedia/superagent/releases) - [Changelog](https://github.com/visionmedia/superagent/blob/master/HISTORY.md) - [Commits](https://github.com/visionmedia/superagent/compare/v5.3.1...v6.0.0) Signed-off-by: dependabot-preview[bot] Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> --- package-lock.json | 6 +++--- package.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index 14c08819e4..35d6d8d316 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12774,9 +12774,9 @@ "integrity": "sha1-6NK6H6nJBXAwPAMLaQD31fiavls=" }, "superagent": { - "version": "5.3.1", - "resolved": "https://registry.npmjs.org/superagent/-/superagent-5.3.1.tgz", - "integrity": "sha512-wjJ/MoTid2/RuGCOFtlacyGNxN9QLMgcpYLDQlWFIhhdJ93kNscFonGvrpAHSCVjRVj++DGCglocF7Aej1KHvQ==", + "version": "6.0.0", + "resolved": "https://registry.npmjs.org/superagent/-/superagent-6.0.0.tgz", + "integrity": "sha512-gBiyDSUR3zbYO8za+MudSNxMFSOhKcZfQ1Anya1DWzk9R32zl++cYUFHXzP3VnyvQO8h/1/uPPA9FUDDtE+qdA==", "requires": { "component-emitter": "^1.3.0", "cookiejar": "^2.1.2", diff --git a/package.json b/package.json index 767eec572b..48b48de8b9 100644 --- a/package.json +++ b/package.json @@ -67,7 +67,7 @@ "rimraf": "^3.0.2", "short-uuid": "^3.0.0", "stripe": "^7.15.0", - "superagent": "^5.3.1", + "superagent": "^6.0.0", "universal-analytics": "^0.4.23", "useragent": "^2.1.9", "uuid": "^8.3.0", From d016c1fa0a6e90d6241c46c40d48ac4d04b37b4b Mon Sep 17 00:00:00 2001 From: Matteo Pagliazzi Date: Mon, 10 Aug 2020 16:20:29 +0200 Subject: [PATCH 12/16] Revert "build(deps): bump mongoose from 5.9.27 to 5.9.28 (#12449)" (#12458) This reverts commit 8796dbd8b8c834ffb24647fab3aebfd99a5db108. --- package-lock.json | 6 +++--- package.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index 35d6d8d316..8fc203e12a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9391,9 +9391,9 @@ } }, "mongoose": { - "version": "5.9.28", - "resolved": "https://registry.npmjs.org/mongoose/-/mongoose-5.9.28.tgz", - "integrity": "sha512-A8lNRk4eCQDzk+DagSMYdH94LAYrbTK83LgrUlzqdig3YXvizW3DApJqOWQ5DdhuimvsfiD0Z5NTVzXl/rgi2w==", + "version": "5.9.27", + "resolved": "https://registry.npmjs.org/mongoose/-/mongoose-5.9.27.tgz", + "integrity": "sha512-N8zj4pj9J2xJ2BnQ4NiIHEtmjPldtbmbEZOMz4phLTQr3KFWPR0T0I6EzQxNioHwmDbHD4VFzbEd755oD2SJxA==", "requires": { "bson": "^1.1.4", "kareem": "2.3.1", diff --git a/package.json b/package.json index 48b48de8b9..b2a6f8c7b1 100644 --- a/package.json +++ b/package.json @@ -48,7 +48,7 @@ "method-override": "^3.0.0", "moment": "^2.27.0", "moment-recur": "^1.0.7", - "mongoose": "^5.9.28", + "mongoose": "^5.9.27", "morgan": "^1.10.0", "nconf": "^0.10.0", "node-gcm": "^1.0.3", From 8c3a9c6dbc0460884fa2f6fa723b2b9feaa3c65f Mon Sep 17 00:00:00 2001 From: Sabe Jones Date: Mon, 10 Aug 2020 11:27:19 -0500 Subject: [PATCH 13/16] fix(teams): smol tweaks (#12443) --- .../client/src/components/tasks/approvalFooter.vue | 4 +++- .../components/tasks/modal-controls/selectMulti.vue | 12 +++++++++--- website/client/src/components/tasks/taskModal.vue | 3 ++- website/server/controllers/api-v3/tasks/groups.js | 2 +- 4 files changed, 15 insertions(+), 6 deletions(-) diff --git a/website/client/src/components/tasks/approvalFooter.vue b/website/client/src/components/tasks/approvalFooter.vue index 519adbffa5..c984247b1c 100644 --- a/website/client/src/components/tasks/approvalFooter.vue +++ b/website/client/src/components/tasks/approvalFooter.vue @@ -3,6 +3,8 @@
{ const index = findIndex(this.group.members, member => member._id === userId); const assignedMember = this.group.members[index]; - assignedUsersNames.push(assignedMember.profile.name); + assignedUsersNames.push(`@${assignedMember.auth.local.username}`); }); } diff --git a/website/client/src/components/tasks/modal-controls/selectMulti.vue b/website/client/src/components/tasks/modal-controls/selectMulti.vue index 7614f0ab9a..7d45f91c84 100644 --- a/website/client/src/components/tasks/modal-controls/selectMulti.vue +++ b/website/client/src/components/tasks/modal-controls/selectMulti.vue @@ -57,10 +57,16 @@ multi