From 1411706963e00bbd8517f545f359eb2cdc0a94c0 Mon Sep 17 00:00:00 2001
From: Matteo Pagliazzi <matteopagliazzi@gmail.com>
Date: Fri, 13 Mar 2020 23:48:10 +0100
Subject: [PATCH] fix(party members): clone array to avoid infinite loops,
 fixes #11969

---
 website/client/src/components/groups/membersModal.vue | 2 +-
 website/client/src/components/header/index.vue        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/website/client/src/components/groups/membersModal.vue b/website/client/src/components/groups/membersModal.vue
index b5d00b8c45..f02e9494c0 100644
--- a/website/client/src/components/groups/membersModal.vue
+++ b/website/client/src/components/groups/membersModal.vue
@@ -475,7 +475,7 @@ export default {
       return this.$store.state.memberModalOptions.challengeId;
     },
     sortedMembers () {
-      let sortedMembers = this.members;
+      let sortedMembers = this.members.slice(); // shallow clone to avoid infinite loop
 
       if (!isEmpty(this.sortOption)) {
         // Use the memberlist filtered by searchTerm
diff --git a/website/client/src/components/header/index.vue b/website/client/src/components/header/index.vue
index a2cb7df1a1..498014ad1b 100644
--- a/website/client/src/components/header/index.vue
+++ b/website/client/src/components/header/index.vue
@@ -170,7 +170,7 @@ export default {
       return Math.floor(this.currentWidth / 140) + 1;
     },
     sortedPartyMembers () {
-      let sortedMembers = this.partyMembers;
+      let sortedMembers = this.partyMembers.slice(); // shallow clone to avoid infinite loop
       const { order, orderAscending } = this.user.party;
 
       if (order === 'profile.name') {