sudoxreboot/habitica
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica.git synced 2026-04-14 19:56:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

WIP remove challenge tag from list if not in use (#14147)

Browse source 
* if tag not in use after leaving challenge, delete

* fix(tags): correct routing in store actions

Co-authored-by: Megan Shepherd <meg.d.shep@gmail.com>
Co-authored-by: SabreCat <sabe@habitica.com>
This commit is contained in:
Megan Searles 2022-12-15 15:17:00 -06:00 committed by GitHub
parent 0224ce7e3e
commit 2eb7bab1dd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
website/client/src/components/challenges/leaveChallengeModal.vue
View file

@ -50,7 +50,21 @@ export default {
challengeId: this.challengeId,
keep,
});
await this.$store.dispatch('tasks:fetchUserTasks', { forceLoad: true });
const userTasksByType = (await this.$store.dispatch('tasks:fetchUserTasks', { forceLoad: true })).data;
let tagInUse = false;
Object.keys(userTasksByType).forEach(taskType => {
userTasksByType[taskType].forEach(task => {
if (task.tags.indexOf(this.challengeId) > -1) {
tagInUse = true;
}
});
});
if (!tagInUse) {
await this.$store.dispatch(
'tags:deleteTag',
{ tagId: this.challengeId },
);
}
this.close();
},
close () {

12
website/client/src/store/actions/tags.js
View file

@ -1,13 +1,13 @@
import axios from 'axios';
export async function getTags () {
const url = 'api/v4/tags';
const url = '/api/v4/tags';
const response = await axios.get(url);
return response.data.data;
}
export async function createTag (store, payload) {
const url = 'api/v4/tags';
const url = '/api/v4/tags';
const response = await axios.post(url, {
name: payload.name,
});
@ -19,13 +19,13 @@ export async function createTag (store, payload) {
}
export async function getTag (store, payload) {
const url = `api/v4/tags/${payload.tagId}`;
const url = `/api/v4/tags/${payload.tagId}`;
const response = await axios.get(url);
return response.data.data;
}
export async function updateTag (store, payload) {
const url = `api/v4/tags/${payload.tagId}`;
const url = `/api/v4/tags/${payload.tagId}`;
const response = await axios.put(url, {
tagDetails: payload.tagDetails,
});
@ -33,7 +33,7 @@ export async function updateTag (store, payload) {
}
export async function sortTag (store, payload) {
const url = 'api/v4/reorder-tags';
const url = '/api/v4/reorder-tags';
const response = await axios.post(url, {
tagId: payload.tagId,
to: payload.to,
@ -42,7 +42,7 @@ export async function sortTag (store, payload) {
}
export async function deleteTag (store, payload) {
const url = `api/v4/tags/${payload.tagId}`;
const url = `/api/v4/tags/${payload.tagId}`;
const response = await axios.delete(url);
return response.data.data;
}