From 33c78c716818dceef86f58c7fa5b03335ee3a73a Mon Sep 17 00:00:00 2001 From: Matteo Pagliazzi Date: Sun, 3 Nov 2013 12:12:43 +0100 Subject: [PATCH] more fixes for guild leaving --- public/js/controllers/groupsCtrl.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/public/js/controllers/groupsCtrl.js b/public/js/controllers/groupsCtrl.js index 4626a54536..6a775f0a7e 100644 --- a/public/js/controllers/groupsCtrl.js +++ b/public/js/controllers/groupsCtrl.js @@ -169,12 +169,10 @@ habitrpg.controller("GroupsCtrl", ['$scope', '$rootScope', 'Groups', '$http', 'A if (confirm("Are you sure you want to leave this guild?") !== true) { return; } - group.$leave(function(group){ + group.$leave(function(){ $scope.groups.guilds.splice(_.indexOf($scope.groups.guilds, group), 1); // remove user from group members if guild is public so that he can re-join it immediately - if(group.privacy == 'public'){ - // slow when a lot of members...? probably yes - //_.remove(group.members, {_id: User.user._id}); Not necessary client side + if(group.privacy == 'public' || !group.privacy){ //public guilds with only some fields fetched var i = _.findIndex($scope.groups.public, {_id: group._id}); if(~i){ var guild = $scope.groups.public[i];