sudoxreboot/habitica
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica.git synced 2026-07-13 15:38:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(tests): short circuit getter, adjust expectations

Browse source
This commit is contained in:
SabreCat 2022-08-22 18:49:56 -05:00
parent 5251598369
commit 3ab88bbb3f
3 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
website/client/src/store/getters/tasks.js
View file

@ -172,7 +172,8 @@ export function getTaskClasses (store) {
if (type === 'todo' || type === 'daily') {
if (task.completed
|| (!shouldDo(dueDate, task, userPreferences) && type === 'daily')
|| (task.group.assignedUsersDetail && task.group.assignedUsersDetail[userId]
|| (task.group && task.group.assignedUsersDetail
&& task.group.assignedUsersDetail[userId]
&& task.group.assignedUsersDetail[userId].completed)
) {
return {

5
website/client/tests/unit/store/getters/tasks/canEdit.spec.js
View file

@ -35,7 +35,10 @@ describe('canEdit getter', () => {
});
it('can Edit task in own dashboard', () => {
expect(store.getters['tasks:canEdit'](task, 'challenge', true, null, challenge)).to.equal(true);
expect(store.getters['tasks:canEdit'](task, 'group', true, group, null)).to.equal(true);
});
it('cannot Edit group task in own dashboard', () => {
expect(store.getters['tasks:canEdit'](task, 'group', true, group, null)).to.equal(false);
});
it('can Edit any challenge task if admin', () => {

9
website/client/tests/unit/store/getters/tasks/getTaskClasses.spec.js
View file

@ -143,7 +143,14 @@ describe('getTaskClasses getter', () => {
});
it('returns noninteractive classes and padlock icons for group board tasks', () => {
const task = { type: 'todo', value: 2, group: { id: 'group-id' } };
const task = {
type: 'todo',
value: 2,
group: {
id: 'group-id',
assignedUsers: ['not-me'],
},
};
expect(getTaskClasses(task, 'control')).to.deep.equal({
bg: 'task-good-control-bg-noninteractive',
checkbox: 'task-good-control-checkbox',