sudoxreboot/habitica
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica.git synced 2026-07-31 15:09:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

try to solve duplicate chat messages issue

Browse source
This commit is contained in:
Tyler Renelle 2013-05-10 11:28:21 +01:00
parent cd6a7fbcc4
commit 4091109998
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/app/party.coffee
View file

@ -100,8 +100,16 @@ module.exports.app = (appExports, model, app) ->
user: helpers.username(model.get('_user.auth'), model.get('_user.profile.name'))
timestamp: +new Date
# FIXME how to remove duplicates ?
chat.unshift message, -> chat.remove 200 # keep a max messages cap
# FIXME - used to be we used chat.unshift(message) (see code before this commit, cd6a7fb), but seemed Racer
# would queue the unshift, and keep trying to send when connection detected. But each send would go through, so we'd
# get tons of duplicates. To avoid that, we're just doing a model.set now, but that has the problem of clobbering
# other senders if sent at the same time
messages = chat.get() || []
messages =_.uniq messages, true, ((m) -> m.id) # get rid of dupes
messages.unshift message
messages.splice(200)
model.set path, messages
model.set(input, '')
model.on 'unshift', '_party.chat', -> $('.chat-message').tooltip()
@ -112,7 +120,6 @@ module.exports.app = (appExports, model, app) ->
model.set '_user.party.lastMessageSeen', model.get('_party.chat')[0].id
appExports.tavernSendChat = ->
model.setNull '_tavern.chat', {messages:[]} #we can remove this later, first time run only
sendChat('_tavern.chat.messages', '_tavernMessage')
appExports.partyMessageKeyup = (e, el, next) ->