From 13e87b1ea05dea99f69482a8539c534e19b5e436 Mon Sep 17 00:00:00 2001 From: SabreCat Date: Tue, 2 May 2023 10:11:57 -0500 Subject: [PATCH 1/9] fix(tests): linting --- .../api/v3/integration/groups/POST-groups_groupId_join.test.js | 1 - test/api/v3/integration/groups/POST-groups_invite.test.js | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/api/v3/integration/groups/POST-groups_groupId_join.test.js b/test/api/v3/integration/groups/POST-groups_groupId_join.test.js index bbad7a8401..2c6313154b 100644 --- a/test/api/v3/integration/groups/POST-groups_groupId_join.test.js +++ b/test/api/v3/integration/groups/POST-groups_groupId_join.test.js @@ -2,7 +2,6 @@ import { v4 as generateUUID } from 'uuid'; import { generateUser, createAndPopulateGroup, - checkExistence, translate as t, } from '../../../../helpers/api-integration/v3'; diff --git a/test/api/v3/integration/groups/POST-groups_invite.test.js b/test/api/v3/integration/groups/POST-groups_invite.test.js index 58a478be00..179e6dfdee 100644 --- a/test/api/v3/integration/groups/POST-groups_invite.test.js +++ b/test/api/v3/integration/groups/POST-groups_invite.test.js @@ -626,7 +626,8 @@ describe('Post /groups/:groupId/invite', () => { }); describe('party size limits', () => { - let party, partyLeader; + let party; + let partyLeader; beforeEach(async () => { group = await createAndPopulateGroup({ From c77dd5f200d51d5e9059c74f1f8da53ff2bd9a66 Mon Sep 17 00:00:00 2001 From: SabreCat Date: Tue, 2 May 2023 16:52:50 -0500 Subject: [PATCH 2/9] fix(analytics): move lfp events out of mounted --- .../client/src/components/groups/createPartyModal.vue | 6 ------ .../client/src/components/groups/lookingForParty.vue | 8 -------- website/client/src/components/header/index.vue | 7 +++++++ website/client/src/router/index.js | 10 ++++++++++ 4 files changed, 17 insertions(+), 14 deletions(-) diff --git a/website/client/src/components/groups/createPartyModal.vue b/website/client/src/components/groups/createPartyModal.vue index 17c0184331..c1021b47e7 100644 --- a/website/client/src/components/groups/createPartyModal.vue +++ b/website/client/src/components/groups/createPartyModal.vue @@ -264,12 +264,6 @@ export default { }, mounted () { this.seeking = Boolean(this.user.party.seeking); - Analytics.track({ - eventName: 'Start a Party button', - eventAction: 'Start a Party button', - eventCategory: 'behavior', - hitType: 'event', - }, { trackOnClient: true }); }, methods: { async createParty () { diff --git a/website/client/src/components/groups/lookingForParty.vue b/website/client/src/components/groups/lookingForParty.vue index eda06f5759..fd22c7656a 100644 --- a/website/client/src/components/groups/lookingForParty.vue +++ b/website/client/src/components/groups/lookingForParty.vue @@ -243,8 +243,6 @@ import rogueIcon from '@/assets/svg/rogue.svg'; import healerIcon from '@/assets/svg/healer.svg'; import wizardIcon from '@/assets/svg/wizard.svg'; -import * as Analytics from '@/libs/analytics'; - export default { components: { Avatar, @@ -287,12 +285,6 @@ export default { section: this.$t('lookingForPartyTitle'), }); this.seekers = await this.$store.dispatch('party:lookingForParty'); - await Analytics.track({ - hitType: 'event', - eventName: 'View Find Members', - eventAction: 'View Find Members', - eventCategory: 'behavior', - }, { trackOnClient: true }); this.canLoadMore = this.seekers.length === 30; this.loading = false; } diff --git a/website/client/src/components/header/index.vue b/website/client/src/components/header/index.vue index ebf2362e32..69da953390 100644 --- a/website/client/src/components/header/index.vue +++ b/website/client/src/components/header/index.vue @@ -122,6 +122,7 @@