From 6f5b9ef119b469478d239d5fbca50656d96f22a6 Mon Sep 17 00:00:00 2001 From: Sabe Jones Date: Fri, 12 Oct 2018 15:27:31 +0000 Subject: [PATCH] fix(scripts): better error handling for script runner and GDPR --- migrations/migration-runner.js | 6 +++--- scripts/gdpr-delete-users.js | 16 +++++++++++----- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/migrations/migration-runner.js b/migrations/migration-runner.js index e9b62d5c2e..c1a0fb5481 100644 --- a/migrations/migration-runner.js +++ b/migrations/migration-runner.js @@ -17,12 +17,12 @@ function setUpServer () { setUpServer(); // Replace this with your migration -const processUsers = require('./users/takeThis.js'); +const processUsers = require('../scripts/gdpr-delete-users.js'); processUsers() .then(function success () { - process.exitCode = 0; + process.exit(0); }) .catch(function failure (err) { console.log(err); - process.exitCode = 1; + process.exit(1); }); diff --git a/scripts/gdpr-delete-users.js b/scripts/gdpr-delete-users.js index d5942dace4..4b61eeec1f 100644 --- a/scripts/gdpr-delete-users.js +++ b/scripts/gdpr-delete-users.js @@ -20,9 +20,11 @@ async function _deleteAmplitudeData (userId, email) { password: AMPLITUDE_SECRET, }, } - ); + ).catch((err) => { + console.log(err.response.data); + }); - console.log(`${response.status} ${response.statusText}`); + if (response) console.log(`${response.status} ${response.statusText}`); } async function _deleteHabiticaData (user) { @@ -44,10 +46,14 @@ async function _deleteHabiticaData (user) { 'x-api-key': user.apiToken, }, } - ); + ).catch((err) => { + console.log(err.response.data); + }); - console.log(`${response.status} ${response.statusText}`); - if (response.status === 200) console.log(`${user._id} removed. Last login: ${user.auth.timestamps.loggedin}`); + if (response) { + console.log(`${response.status} ${response.statusText}`); + if (response.status === 200) console.log(`${user._id} removed. Last login: ${user.auth.timestamps.loggedin}`); + } } async function _processEmailAddress (email) {