sudoxreboot/habitica
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica.git synced 2026-07-09 05:47:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(autoAllocate): don't detrain stats on ripening To-Dos

Browse source 
Previously, on cron, the reddening of To-Dos would subtract from the stat training for task-based auto-allocation. This had a tendency to cause users with lots of active tasks to get backward stat allocations on levelup. Now the "down" direction for To-Dos is not counted for attribute training. (Missed Dailies will still detrain.)

Fixes HabitRPG/habitrpg/#2247
This commit is contained in:
Sabe Jones 2014-01-19 09:36:23 -06:00
parent 2ae7d1dede
commit 70394ea0b9
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
dist/habitrpg-shared.js vendored
View file

@ -12046,7 +12046,7 @@ var process=require("__browserify_process");(function() {
}
}
if (task.type !== 'reward') {
if (user.preferences.automaticAllocation === true && user.preferences.allocationMode === 'taskbased') {
if (user.preferences.automaticAllocation === true && user.preferences.allocationMode === 'taskbased' && !(task.type === 'todo' && direction === 'down')) {
user.stats.training[task.attribute] += nextDelta;
}
adjustAmt = nextDelta;

2
script/index.coffee
View file

@ -760,7 +760,7 @@ api.wrap = (user, main=true) ->
nextDelta *= task.checklist.length
unless task.type is 'reward'
if (user.preferences.automaticAllocation is true and user.preferences.allocationMode is 'taskbased') then user.stats.training[task.attribute] += nextDelta
if (user.preferences.automaticAllocation is true and user.preferences.allocationMode is 'taskbased' and !(task.type is 'todo' and direction is 'down')) then user.stats.training[task.attribute] += nextDelta
adjustAmt = nextDelta
# ===== STRENGTH =====
# (Only for up-scoring, ignore up-onlies and rewards)