improve appearance and wording in Hall's Reward User form for admins (#11248)

- adds Username
- changes placeholders to labels (subheadings) for consistency
- lists common and rare contributor titles to assist with keeping them consistent
- converts translated text to hard-coded English for consistency and to minimise work for translators
- removes unused locale strings

website/client/components/hall/heroes.vue

@@ -3,7 +3,7 @@
   small.muted(v-html="$t('blurbHallContributors')")
   .well
     div(v-if='user.contributor.admin')
-      h2 {{ $t('rewardUser') }}
+      h2 Reward User
 
       .row
         .form.col-6(v-if='!hero.profile')
@@ -11,33 +11,33 @@
             input.form-control(type='text', v-model='heroID', :placeholder="'User ID or Username'")
           .form-group
             button.btn.btn-secondary(@click='loadHero(heroID)')
-              | {{ $t('loadUser') }}
+              | Load User
 
       .row
         .form.col-6(v-if='hero && hero.profile', submit='saveHero(hero)')
           router-link(:to="{'name': 'userProfile', 'params': {'userId': hero._id}}")
-            h3 {{hero.profile.name}}
+            h3 @{{hero.auth.local.username}}   /   {{hero.profile.name}}
           .form-group
-            input.form-control(type='text', v-model='hero.contributor.text', :placeholder="$t('contribTitle')")
+            label Contributor Title
+            input.form-control(type='text', v-model='hero.contributor.text')
+            small Common titles: <strong>Ambassador, Artisan, Bard, Blacksmith, Challenger, Comrade, Fletcher, Linguist, Linguistic Scribe, Scribe, Socialite, Storyteller</strong>. Rare titles: Advisor, Chamberlain, Designer, Mathematician, Shirtster, Spokesperson, Statistician, Tinker, Transcriber, Troubadour.
           .form-group
-            label {{ $t('contribLevel') }}
+            label Contributor Tier
             input.form-control(type='number', v-model='hero.contributor.level')
-            small {{ $t('contribHallText') }}
+            small 1-7 for normal contributors, 8 for moderators, 9 for staff. This determines which items, pets, and mounts are available, and name-tag coloring. Tiers 8 and 9 are automatically given admin status.
               |&nbsp;
-              a(target='_blank', href='https://trello.com/c/wkFzONhE/277-contributor-gear') {{ $t('moreDetails') }}
+              a(target='_blank', href='https://trello.com/c/wkFzONhE/277-contributor-gear') More details (1-7)
               |,&nbsp;
-              a(target='_blank', href='https://github.com/HabitRPG/habitica/issues/3801') {{ $t('moreDetails2') }}
+              a(target='_blank', href='https://github.com/HabitRPG/habitica/issues/3801') more details (8-9)
           .form-group
-            textarea.form-control(cols=5, :placeholder="$t('contributions')", v-model='hero.contributor.contributions')
-            //include ../../shared/formattiv-help
-          hr
+            label Contributions
+            textarea.form-control(cols=5, v-model='hero.contributor.contributions')
 
           .form-group
-            label {{ $t('balance') }}
+            label Balance
             input.form-control(type='number', step="any", v-model='hero.balance')
             small
-              span ‘{{ hero.balance }}’&nbsp;
-              span(v-html='$t("notGems")')
+              span '{{ hero.balance }}' is in USD, <em>not</em> in Gems. E.g., if this number is 1, it means 4 Gems. Only use this option when manually granting Gems to players, don't use it when granting contributor tiers. Contrib tiers will automatically add Gems.
           .accordion
             .accordion-group(heading='Items')
               h4.expand-toggle(:class="{'open': expandItems}", @click="expandItems = !expandItems") Update Item
@@ -71,7 +71,7 @@
           // Add backer stuff like tier, disable adds, etcs
           .form-group
             button.form-control.btn.btn-primary(@click='saveHero()')
-              | {{ $t('save') }}
+              | Save
 
     .table-responsive
       table.table.table-striped

website/common/locales/en/contrib.json

@@ -40,26 +40,18 @@
   "helpedText1": "Helped Habitica grow by filling out",
   "helpedText2": "this survey.",
   "hall": "Hall of Heroes",
-  "contribTitle": "Contributor Title (eg, \"Blacksmith\")",
   "contribLevel": "Contrib Tier",
-  "contribHallText": "1-7 for normal contributors, 8 for moderators, 9 for staff. This determines which items, pets, and mounts are available. Also determines name-tag coloring. Tiers 8 and 9 are automatically given admin status.",
   "hallContributors": "Hall of Contributors",
   "hallPatrons": "Hall of Patrons",
-  "rewardUser": "Reward User",
   "UUID": "User ID",
-  "loadUser": "Load User",
   "noAdminAccess": "You don't have admin access.",
   "userNotFound": "User not found.",
   "invalidUUID": "UUID must be valid",
   "title": "Title",
-  "moreDetails": "More details (1-7)",
-  "moreDetails2": "more details (8-9)",
   "contributions": "Contributions",
   "admin": "Admin",
-  "notGems": "is in USD, <em>not</em> in Gems. Aka, if this number is 1, it means 4 gems. Only use this option when manually granting gems to players, don't use it when granting contributor tiers. Contrib tiers will automatically add gems.",
   "gamemaster": "Game Master (staff/moderator)",
   "backerTier": "Backer Tier",
-  "balance": "Balance",
   "tierPop": "Click tier labels for details.",
   "playerTiers": "Player Tiers",
   "tier": "Tier",