From 983aae7f873b3626485b84f1b43926a7415a4fa5 Mon Sep 17 00:00:00 2001
From: jbusa22 <41833473+jbusa22@users.noreply.github.com>
Date: Mon, 9 Nov 2020 06:25:22 -0500
Subject: [PATCH] Fixes #12730 - Tag filter not always cleared correctly when
 deleting active tag (#12737)

* Update title for tabs not including challenges, guild and team

* add section titles to challenges, guilds, and groups

* Update dynamic title to use vuex action

* Remove duplicate key

* Actually remove duplicate key

* Fix section sub section in group

* Add note to implement setTitle when adding a page

* Add missing sections to dynamic title

* Features string not translated

* Use onGroupUpdate to update group titles

* Add watcher to challenges for dynamic title updates

* Small fixes

* Add register and login to title, remove duplicate keys

* Add home page dynamic title functionality

* Minor name changes

* Fix tag filtering on deletion

* Remove debuggers

Co-authored-by: Matteo Pagliazzi <matteopagliazzi@gmail.com>
---
 website/client/src/components/tasks/user.vue | 8 +++++++-
 website/client/src/router/index.js           | 2 ++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/website/client/src/components/tasks/user.vue b/website/client/src/components/tasks/user.vue
index 30669ea80d..fdd544a26f 100644
--- a/website/client/src/components/tasks/user.vue
+++ b/website/client/src/components/tasks/user.vue
@@ -520,7 +520,13 @@ export default {
     removeTag (index, key) {
       const tagId = this.tagsSnap[key][index].id;
       const indexInSelected = this.selectedTags.indexOf(tagId);
-      if (indexInSelected !== -1) this.$delete(this.selectedTags, indexInSelected);
+      const indexInTempSelected = this.temporarilySelectedTags.indexOf(tagId);
+      if (indexInSelected !== -1) {
+        this.$delete(this.selectedTags, indexInSelected);
+      }
+      if (indexInTempSelected !== -1) {
+        this.$delete(this.temporarilySelectedTags, indexInTempSelected);
+      }
       this.$delete(this.tagsSnap[key], index);
     },
     saveTags () {
diff --git a/website/client/src/router/index.js b/website/client/src/router/index.js
index 9db7348ec7..fea7dfd109 100644
--- a/website/client/src/router/index.js
+++ b/website/client/src/router/index.js
@@ -6,6 +6,8 @@ import handleRedirect from './handleRedirect';
 
 import ParentPage from '@/components/parentPage';
 
+// NOTE: when adding a page make sure to implement setTitle
+
 // Static Pages
 const StaticWrapper = () => import(/* webpackChunkName: "entry" */'@/components/static/staticWrapper');
 const HomePage = () => import(/* webpackChunkName: "entry" */'@/components/static/home');