From 9a4e8d38b46d02475ca97121b5d77a777f8d1f92 Mon Sep 17 00:00:00 2001
From: Tyler Renelle <tylerrenelle@gmail.com>
Date: Wed, 14 May 2014 10:21:15 -0600
Subject: [PATCH] fix(quests): don't allow questStart on already-started quests

---
 src/controllers/groups.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/controllers/groups.js b/src/controllers/groups.js
index 29a4954eec..219c1a39a3 100644
--- a/src/controllers/groups.js
+++ b/src/controllers/groups.js
@@ -488,9 +488,10 @@ api.removeMember = function(req, res, next){
 
 questStart = function(req, res, next) {
   var group = res.locals.group;
-  var user = res.locals.user;
   var force = req.query.force;
 
+  if (group.quest.active) return res.json(400,{err:'Quest already began.'});
+
   group.markModified('quest');
 
   // Not ready yet, wait till everyone's accepted, rejected, or we force-start
@@ -516,7 +517,7 @@ questStart = function(req, res, next) {
     if (group.quest.members[m] == true) {
       // See https://github.com/HabitRPG/habitrpg/issues/2168#issuecomment-31556322 , we need to *not* reset party.quest.progress.up
       //updates['$set']['party.quest'] = Group.cleanQuestProgress({key:key,progress:{collect:collected}});
-      updates['$set']['party.quest.key'] = key
+      updates['$set']['party.quest.key'] = key;
       updates['$set']['party.quest.progress.down'] = 0;
       updates['$set']['party.quest.progress.collect'] = collected;
       updates['$set']['party.quest.completed'] = null;