sudoxreboot/habitica
1
0
Fork 0
mirror of https://github.com/sudoxnym/habitica.git synced 2026-07-22 03:34:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't persist properties of tag filters (#7564)

Browse source 
* fix(filters): don't persist tag props
Partial fix for #7412

* fix(test): correct expectation
This commit is contained in:
Sabe Jones 2016-05-31 14:55:59 -05:00
parent 0b122f3b43
commit 9b56c6f2ba
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
test/spec/controllers/filtersCtrlSpec.js
View file

@ -27,7 +27,7 @@ describe('Filters Controller', function() {
scope.toggleFilter(tag);
expect(userService.user.filters[tag.id]).to.eql(true);
scope.toggleFilter(tag);
expect(userService.user.filters[tag.id]).to.eql(false);
expect(userService.user.filters[tag.id]).to.not.eql(true);
}));
});

2
website/client/js/controllers/filtersCtrl.js
View file

@ -28,7 +28,7 @@ habitrpg.controller("FiltersCtrl", ['$scope', '$rootScope', 'User', 'Shared',
if (!user.filters[tag.id]) {
user.filters[tag.id] = true;
} else {
user.filters[tag.id] = !user.filters[tag.id];
delete user.filters[tag.id];
}
// no longer persisting this, it was causing a lot of confusion - users thought they'd permanently lost tasks